From 49f2ec70bcd5921ca4329d730852b988cc22573a Mon Sep 17 00:00:00 2001 From: Arun Kumar Khandavalli Date: Tue, 23 Jun 2020 20:59:17 +0530 Subject: [PATCH] qcacmn: Remove load/unload log in diag reporting There are multiple places in the driver where the diag events are reported and if the unload has started these diag events are logged and dropped if there is storm of diag events because of some thread message flushing this logging of the message will cause excessive logging. Remove the log as driver is unloading and it won't be sending it userspace logging either. Change-Id: Ie4c5caf44ad509da213f1bc76ff6ef6dfeecde2d CRs-Fixed: 2716899 --- utils/host_diag_log/src/host_diag_log.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/utils/host_diag_log/src/host_diag_log.c b/utils/host_diag_log/src/host_diag_log.c index 97e51f6542b8..f42743e9c8ac 100644 --- a/utils/host_diag_log/src/host_diag_log.c +++ b/utils/host_diag_log/src/host_diag_log.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2014-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -109,12 +109,8 @@ void host_diag_log_submit(void *plog_hdr_ptr) uint16_t data_len; uint16_t total_len; - if (cds_is_load_or_unload_in_progress()) { - QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_INFO, - "%s: Unloading/Loading in Progress. Ignore!!!", - __func__); + if (cds_is_load_or_unload_in_progress()) return; - } if (nl_srv_is_initialized() != 0) return; @@ -201,12 +197,8 @@ void host_diag_event_report_payload(uint16_t event_Id, uint16_t length, event_report_t *pEvent_report; uint16_t total_len; - if (cds_is_load_or_unload_in_progress()) { - QDF_TRACE(QDF_MODULE_ID_QDF, QDF_TRACE_LEVEL_INFO, - "%s: Unloading/Loading in Progress. Ignore!!!", - __func__); + if (cds_is_load_or_unload_in_progress()) return; - } if (nl_srv_is_initialized() != 0) return;