drivers/mailbox/omap: make mbox->irq signed for error handling

There is a bug in omap2_mbox_probe() where we try do:

		mbox->irq = platform_get_irq(pdev, info->irq_id);
		if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: Dan Carpenter <[email protected]>
Cc: Suman Anna <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Omar Ramirez Luna <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Dan Carpenter 2014-01-23 15:53:45 -08:00 • committed by Linus Torvalds
commit 4a102b4d14

View file

@ -52,7 +52,7 @@ struct omap_mbox_queue {
struct omap_mbox {
const char *name;
unsigned int irq;
int irq;
struct omap_mbox_queue *txq, *rxq;
struct omap_mbox_ops *ops;
struct device *dev;