From 4dc669fa7e8e75db2250eab9359e2d838f9a4785 Mon Sep 17 00:00:00 2001 From: Sudheer Papothi Date: Wed, 3 Jun 2020 08:36:36 +0530 Subject: [PATCH] soc: soundwire: update soundwire debug logs Update soundwire debug logs to avoid confusion during soundwire enumeration of slaves. Change-Id: Ib265fb3bf777a1461a9041bb269cdcb5c9ac5e2b Signed-off-by: Sudheer Papothi --- soc/soundwire.c | 6 +----- soc/swr-mstr-ctrl.c | 14 ++++++++------ 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/soc/soundwire.c b/soc/soundwire.c index 72a94ace1482..04b74f82705a 100644 --- a/soc/soundwire.c +++ b/soc/soundwire.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * Copyright (c) 2015-2019, The Linux Foundation. All rights reserved. + * Copyright (c) 2015-2020, The Linux Foundation. All rights reserved. */ #include @@ -473,10 +473,6 @@ int swr_get_logical_dev_num(struct swr_device *dev, u64 dev_id, } mutex_lock(&master->mlock); ret = master->get_logical_dev_num(master, dev_id, dev_num); - if (ret) { - pr_err("%s: Error %d to get logical addr for device %llx\n", - __func__, ret, dev_id); - } mutex_unlock(&master->mlock); return ret; } diff --git a/soc/swr-mstr-ctrl.c b/soc/swr-mstr-ctrl.c index b2853b399ab6..f2030a17c7fc 100644 --- a/soc/swr-mstr-ctrl.c +++ b/soc/swr-mstr-ctrl.c @@ -1873,7 +1873,7 @@ handle_irq: swrm_enable_slave_irq(swrm); if (status == swrm->slave_status) { dev_dbg(swrm->dev, - "%s: No change in slave status: %d\n", + "%s: No change in slave status: 0x%x\n", __func__, status); break; } @@ -2177,17 +2177,19 @@ static int swrm_get_logical_dev_num(struct swr_master *mstr, u64 dev_id, if ((id & SWR_DEV_ID_MASK) == dev_id) { *dev_num = i; ret = 0; + dev_info(swrm->dev, + "%s: devnum %d assigned for dev %llx\n", + __func__, i, + swr_dev->addr); } - dev_dbg(swrm->dev, - "%s: devnum %d is assigned for dev addr %lx\n", - __func__, i, swr_dev->addr); } } } } if (ret) - dev_err(swrm->dev, "%s: device 0x%llx is not ready\n", - __func__, dev_id); + dev_err_ratelimited(swrm->dev, + "%s: device 0x%llx is not ready\n", + __func__, dev_id); pm_runtime_mark_last_busy(swrm->dev); pm_runtime_put_autosuspend(swrm->dev);