From 4dfc0eec9bb5fcd615c9bf46d5ac8b61d0d3b2d9 Mon Sep 17 00:00:00 2001 From: Abhishek Singh Date: Thu, 30 Jan 2020 14:49:19 +0530 Subject: [PATCH] qcacld-3.0: Optimize logs in serialization Remove redundant logs and optimize the logs in serialization. Change-Id: Iab3f6dce6067ceac94ca53fe36ca9027b6d9ca50 CRs-Fixed: 2612824 --- core/sme/src/common/sme_api.c | 6 +----- core/sme/src/csr/csr_api_roam.c | 18 ++++-------------- 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/core/sme/src/common/sme_api.c b/core/sme/src/common/sme_api.c index 850ad3c913f7..77e2066fec92 100644 --- a/core/sme/src/common/sme_api.c +++ b/core/sme/src/common/sme_api.c @@ -567,14 +567,11 @@ QDF_STATUS sme_ser_cmd_callback(struct wlan_serialization_command *cmd, switch (reason) { case WLAN_SER_CB_ACTIVATE_CMD: - sme_debug("WLAN_SER_CB_ACTIVATE_CMD callback"); status = sme_ser_handle_active_cmd(cmd); break; case WLAN_SER_CB_CANCEL_CMD: - sme_debug("WLAN_SER_CB_CANCEL_CMD callback"); break; case WLAN_SER_CB_RELEASE_MEM_CMD: - sme_debug("WLAN_SER_CB_RELEASE_MEM_CMD callback"); if (cmd->vdev) wlan_objmgr_vdev_release_ref(cmd->vdev, WLAN_LEGACY_SME_ID); @@ -582,10 +579,9 @@ QDF_STATUS sme_ser_cmd_callback(struct wlan_serialization_command *cmd, csr_release_command_buffer(mac_ctx, sme_cmd); break; case WLAN_SER_CB_ACTIVE_CMD_TIMEOUT: - sme_debug("WLAN_SER_CB_ACTIVE_CMD_TIMEOUT callback"); break; default: - sme_debug("STOP: unknown reason code"); + sme_debug("unknown reason code"); return QDF_STATUS_E_FAILURE; } return status; diff --git a/core/sme/src/csr/csr_api_roam.c b/core/sme/src/csr/csr_api_roam.c index 2e4b17c65deb..57ffab4cd158 100644 --- a/core/sme/src/csr/csr_api_roam.c +++ b/core/sme/src/csr/csr_api_roam.c @@ -19566,26 +19566,21 @@ void csr_release_command(struct mac_context *mac_ctx, tSmeCmd *sme_cmd) cmd_info.req_type = WLAN_SER_CANCEL_NON_SCAN_CMD; cmd_info.cmd_type = csr_get_cmd_type(sme_cmd); cmd_info.vdev = vdev; - sme_debug("cmd_id = %d type %d", sme_cmd->cmd_id, cmd_info.cmd_type); qdf_mem_zero(&cmd, sizeof(struct wlan_serialization_command)); cmd.cmd_id = cmd_info.cmd_id; cmd.cmd_type = cmd_info.cmd_type; cmd.vdev = cmd_info.vdev; if (wlan_serialization_is_cmd_present_in_active_queue( mac_ctx->psoc, &cmd)) { - sme_debug("Releasing active cmd_id[%d] cmd_type[%d]", - cmd_info.cmd_id, cmd_info.cmd_type); cmd_info.queue_type = WLAN_SERIALIZATION_ACTIVE_QUEUE; wlan_serialization_remove_cmd(&cmd_info); } else if (wlan_serialization_is_cmd_present_in_pending_queue( mac_ctx->psoc, &cmd)) { - sme_debug("Releasing pending cmd_id[%d] cmd_type[%d]", - cmd_info.cmd_id, cmd_info.cmd_type); cmd_info.queue_type = WLAN_SERIALIZATION_PENDING_QUEUE; wlan_serialization_cancel_request(&cmd_info); } else { - sme_debug("can't find cmd_id[%d] cmd_type[%d]", - cmd_info.cmd_id, cmd_info.cmd_type); + sme_debug("can't find cmd_id %d cmd_type %d", cmd_info.cmd_id, + cmd_info.cmd_type); } if (cmd_info.vdev) wlan_objmgr_vdev_release_ref(cmd_info.vdev, WLAN_LEGACY_SME_ID); @@ -19741,9 +19736,6 @@ static void csr_fill_cmd_timeout(struct wlan_serialization_command *cmd) cmd->cmd_timeout_duration = SME_ACTIVE_LIST_CMD_TIMEOUT_VALUE; break; } - - sme_debug("cmd_type %d, timeout %d", cmd->cmd_type, - cmd->cmd_timeout_duration); } QDF_STATUS csr_set_serialization_params_to_cmd(struct mac_context *mac_ctx, @@ -19767,13 +19759,11 @@ QDF_STATUS csr_set_serialization_params_to_cmd(struct mac_context *mac_ctx, */ sme_cmd->cmd_id = csr_get_monotonous_number(mac_ctx); cmd->cmd_id = sme_cmd->cmd_id; - sme_debug("cmd_id = %d", cmd->cmd_id); cmd->cmd_type = csr_get_cmd_type(sme_cmd); - sme_debug("filled cmd_type[%d] cmd_id[%d]", - cmd->cmd_type, cmd->cmd_id); if (cmd->cmd_type == WLAN_SER_CMD_MAX) { - sme_err("serialization enum not found"); + sme_err("serialization enum not found for sme_cmd type %d", + sme_cmd->command); return status; } cmd->vdev = wlan_objmgr_get_vdev_by_id_from_psoc(mac_ctx->psoc,