From 4e5ffd3ce0f136ff5e7ef785c5c5d434646a1fa8 Mon Sep 17 00:00:00 2001 From: Mukund Madhusudan Atre Date: Sun, 16 Feb 2020 22:47:44 -0800 Subject: [PATCH] msm: camera: cci: Add device managed alloc to balance free in remove The devm_kfree call in remove is unbalanced without a devm_kzalloc. Add required kzalloc and free during probe to balance it. CRs-Fixed: 2584631 Change-Id: I14164405e62036f7918b858d978afe454e4feb4a Signed-off-by: Mukund Madhusudan Atre --- drivers/cam_sensor_module/cam_cci/cam_cci_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cam_sensor_module/cam_cci/cam_cci_dev.c b/drivers/cam_sensor_module/cam_cci/cam_cci_dev.c index 85cc359ec996..cd937016298c 100644 --- a/drivers/cam_sensor_module/cam_cci/cam_cci_dev.c +++ b/drivers/cam_sensor_module/cam_cci/cam_cci_dev.c @@ -376,7 +376,7 @@ static int cam_cci_component_bind(struct device *dev, int rc = 0; struct platform_device *pdev = to_platform_device(dev); - new_cci_dev = kzalloc(sizeof(struct cci_device), + new_cci_dev = devm_kzalloc(&pdev->dev, sizeof(struct cci_device), GFP_KERNEL); if (!new_cci_dev) return -ENOMEM; @@ -445,7 +445,7 @@ static int cam_cci_component_bind(struct device *dev, CAM_DBG(CAM_CCI, "Component bound successfully"); return rc; cci_no_resource: - kfree(new_cci_dev); + devm_kfree(&pdev->dev, new_cci_dev); return rc; }