A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-10 14:19:09 -04:00
Code Issues Projects Releases Packages Wiki Activity

usb: host: xhci-plat: Avoid unneeded internal declaration warning

Browse source 
When compiling with clang, the following warning is thrown:

drivers/usb/host/xhci-plat.c:443:36: warning: variable
'usb_xhci_acpi_match' is not needed and will not be emitted
[-Wunneeded-internal-declaration]

This happens because the reference to the usb_xhci_acpi_match table
is wrapped in the ACPI_PTR() macro which is NULL when CONFIG_ACPI
is not defined.

While __maybe_unused could be used here to quell the warning, this
patch opts to simply wrap the definition of the match table within
which follows the pattern used by other drivers.

Change-Id: I92bdee0d22a99600ff085fe7089e16b93175abbc
Signed-off-by: Jack Pham <jackp@codeaurora.org>
This commit is contained in:
Jack Pham 2019-07-15 22:40:29 -07:00
commit 50bfde8d6e
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/usb/host/xhci-plat.c
View file

@ -440,12 +440,14 @@ static const struct dev_pm_ops xhci_plat_pm_ops = {
NULL)
};
#ifdef CONFIG_ACPI
static const struct acpi_device_id usb_xhci_acpi_match[] = {
/* XHCI-compliant USB Controller */
{ "PNP0D10", },
{ }
};
MODULE_DEVICE_TABLE(acpi, usb_xhci_acpi_match);
#endif
static struct platform_driver usb_xhci_driver = {
.probe = xhci_plat_probe,