From 29204b2e9e354144c037a3896d15f812a6dd2460 Mon Sep 17 00:00:00 2001 From: Puranam V G Tejaswi Date: Fri, 18 Jun 2021 15:33:47 +0530 Subject: [PATCH] msm: kgsl: Free the memory allocated for pages array in failure case kgsl_system_alloc_pages and kgsl_pool_alloc_pages allocate memory for pages array. This memory is not freed in kgsl_alloc_secure_pages in some failure cases. Free the allocated memory in case of failure to avoid memory leak issues. Change-Id: Ifed2573506d549f60d01f8d3ba06cbabdc9878e0 Signed-off-by: Puranam V G Tejaswi --- drivers/gpu/msm/kgsl_sharedmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/msm/kgsl_sharedmem.c b/drivers/gpu/msm/kgsl_sharedmem.c index 481bbf8f2a68..ae66f3acba30 100644 --- a/drivers/gpu/msm/kgsl_sharedmem.c +++ b/drivers/gpu/msm/kgsl_sharedmem.c @@ -1170,6 +1170,7 @@ static int kgsl_alloc_secure_pages(struct kgsl_device *device, sgt = kzalloc(sizeof(*sgt), GFP_KERNEL); if (!sgt) { kgsl_pool_free_pages(pages, count); + kvfree(pages); return -ENOMEM; } @@ -1177,6 +1178,7 @@ static int kgsl_alloc_secure_pages(struct kgsl_device *device, if (ret) { kfree(sgt); kgsl_pool_free_pages(pages, count); + kvfree(pages); return ret; }