From 542a5eeeb8ba3bfafcab1891a7cc8219bdbd3381 Mon Sep 17 00:00:00 2001 From: Houston Hoffman Date: Thu, 3 Sep 2015 13:51:30 -0700 Subject: [PATCH] qcacld-3.0: Remove ce_disable_any_copy_compl_intr Remove ce_disable_any_copy_compl_intr and ce_enable_any_copy_compl_intr since they aren't used and give a false sense of thread safety. Modifying copy complete interrupt currently needs to be synchronized with completion handling. Change-Id: Ieb27a8c71363ebd56f16eda9e1037a161a5eeb62 CRs-Fixed: 941355 --- core/hif/src/ce/ce_api.h | 2 -- core/hif/src/ce/ce_service.c | 15 --------------- 2 files changed, 17 deletions(-) diff --git a/core/hif/src/ce/ce_api.h b/core/hif/src/ce/ce_api.h index 61038e61b27a..473e383b324b 100644 --- a/core/hif/src/ce/ce_api.h +++ b/core/hif/src/ce/ce_api.h @@ -376,8 +376,6 @@ int ce_per_engine_service(struct ol_softc *scn, unsigned int CE_id); void ce_per_engine_servicereap(struct ol_softc *scn, unsigned int CE_id); /*===================CE cmpl interrupt Enable/Disable =======================*/ -void ce_disable_any_copy_compl_intr(struct ol_softc *scn); -void ce_enable_any_copy_compl_intr(struct ol_softc *scn); void ce_disable_any_copy_compl_intr_nolock(struct ol_softc *scn); void ce_enable_any_copy_compl_intr_nolock(struct ol_softc *scn); diff --git a/core/hif/src/ce/ce_service.c b/core/hif/src/ce/ce_service.c index 710b4149b49d..1636c14930eb 100644 --- a/core/hif/src/ce/ce_service.c +++ b/core/hif/src/ce/ce_service.c @@ -1490,21 +1490,6 @@ void ce_enable_any_copy_compl_intr_nolock(struct ol_softc *scn) A_TARGET_ACCESS_END(scn); } -void ce_disable_any_copy_compl_intr(struct ol_softc *scn) -{ - cdf_spin_lock(&scn->target_lock); - ce_disable_any_copy_compl_intr_nolock(scn); - cdf_spin_unlock(&scn->target_lock); -} - -/*Re-enable the copy compl interrupt if it has not been disabled before.*/ -void ce_enable_any_copy_compl_intr(struct ol_softc *scn) -{ - cdf_spin_lock(&scn->target_lock); - ce_enable_any_copy_compl_intr_nolock(scn); - cdf_spin_unlock(&scn->target_lock); -} - /** * ce_send_cb_register(): register completion handler * @copyeng: CE_state representing the ce we are adding the behavior to