From 54e781e95bfeaa00672b97d7705c6e0d61ebad2d Mon Sep 17 00:00:00 2001 From: Raghavendra Rao Ananta Date: Fri, 6 Dec 2019 09:52:29 -0800 Subject: [PATCH] firmware: qcom_scm: Check for NULL before dereferencing __scm The function qcom_scm_get_sec_dump_state dereferences __scm without checking for NULL and could potentially lead to a NULL pointer exception. This scenario can happen if the clinet calls qcom_scm_get_sec_dump_state before qcom_scm driver is even probed. Hence, check for NULL before dereferencing it. Change-Id: Ic6f7c2b2d616645ea69a8c594c90dc01d689637f Signed-off-by: Raghavendra Rao Ananta --- drivers/firmware/qcom_scm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 3691cbba9f3c..35078f89c911 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -329,7 +329,7 @@ static const struct reset_control_ops qcom_scm_pas_reset_ops = { int qcom_scm_get_sec_dump_state(u32 *dump_state) { - return __qcom_scm_get_sec_dump_state(__scm->dev, + return __qcom_scm_get_sec_dump_state(__scm ? __scm->dev : NULL, dump_state); } EXPORT_SYMBOL(qcom_scm_get_sec_dump_state);