From 56ad1a9fbcbb6fb04732792da9637872e23ca899 Mon Sep 17 00:00:00 2001 From: Jianmin Zhu Date: Tue, 18 Aug 2020 07:51:03 +0800 Subject: [PATCH] qcacld-3.0: NULL pointer may be dereferenced Pointer 'chan' checked for NULL will be dereferenced Change-Id: If5137767a78ac3166d5ae03cb741caefc895bd99 CRs-Fixed: 2757250 --- core/wma/src/wma_scan_roam.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/core/wma/src/wma_scan_roam.c b/core/wma/src/wma_scan_roam.c index 54c354d44c49..d0ede35b4175 100644 --- a/core/wma/src/wma_scan_roam.c +++ b/core/wma/src/wma_scan_roam.c @@ -2872,10 +2872,14 @@ static void wma_update_phymode_on_roam(tp_wma_handle wma, uint8_t *bssid, des_chan = wlan_vdev_mlme_get_des_chan(iface->vdev); bss_chan = wlan_vdev_mlme_get_bss_chan(iface->vdev); des_chan->ch_phymode = bss_phymode; - des_chan->ch_freq = chan->mhz; - des_chan->ch_cfreq1 = chan->band_center_freq1; - des_chan->ch_cfreq2 = chan->band_center_freq2; des_chan->ch_width = iface->chan_width; + if (chan) { + des_chan->ch_freq = chan->mhz; + des_chan->ch_cfreq1 = chan->band_center_freq1; + des_chan->ch_cfreq2 = chan->band_center_freq2; + } else { + wma_err("LFR3: invalid chan"); + } qdf_mem_copy(bss_chan, des_chan, sizeof(struct wlan_channel)); if (!vdev_mlme)