From a145e0954197286657a9b895998ba0d7b833a1eb Mon Sep 17 00:00:00 2001 From: Dustin Brown Date: Thu, 9 Nov 2017 14:38:24 -0800 Subject: [PATCH 1/2] qcacmn: Free hotplug handler in qdf_cpuhp_unregister A hotplug handler is allocated by calling qdf_cpuhp_register. However, qdf_cpuhp_unregister does not free the previously allocated memory. Free the hotplug handler in qdf_cpuhp_unregister. Change-Id: I1663f5ea29a8630b42be33abd824135b0fbe4845 CRs-Fixed: 2141119 --- qdf/src/qdf_cpuhp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qdf/src/qdf_cpuhp.c b/qdf/src/qdf_cpuhp.c index ccccafd8f718..0573583f3c9f 100644 --- a/qdf/src/qdf_cpuhp.c +++ b/qdf/src/qdf_cpuhp.c @@ -152,6 +152,7 @@ void qdf_cpuhp_unregister(struct qdf_cpuhp_handler **out_handler) qdf_list_remove_node(&qdf_cpuhp_handlers, &handler->node); qdf_mutex_release(&qdf_cpuhp_lock); + qdf_mem_free(handler); *out_handler = NULL; } From 1493b989c705762b6595e70db4754472e72c0600 Mon Sep 17 00:00:00 2001 From: Arif Hussain Date: Thu, 2 Nov 2017 17:18:39 -0700 Subject: [PATCH 2/2] qcacmn: serialization: Replace instances of unadorned %p Replace instances of unadorned %p in serialization. Change-Id: I9ae7cb5dc231e689d029d77b1dc7b081a93af0c3 CRs-Fixed: 2133328 --- .../serialization/src/wlan_serialization_dequeue.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/umac/cmn_services/serialization/src/wlan_serialization_dequeue.c b/umac/cmn_services/serialization/src/wlan_serialization_dequeue.c index 5fd0d5f3dad1..8abbda1e4237 100644 --- a/umac/cmn_services/serialization/src/wlan_serialization_dequeue.c +++ b/umac/cmn_services/serialization/src/wlan_serialization_dequeue.c @@ -134,10 +134,8 @@ wlan_serialization_remove_all_cmd_from_queue(qdf_list_t *queue, */ if (is_active_queue) { if (!psoc || !cmd_list) { - serialization_err("Can't find cmd psoc:0x%p", - psoc); - serialization_err("Can't find cmd cmd_list:0x%p", - cmd_list); + serialization_err("psoc:0x%pK, cmd_list:0x%pK", + psoc, cmd_list); status = WLAN_SER_CMD_NOT_FOUND; break; }