A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 21:59:12 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Fix error handling cases in mac_open

Browse source 
Address remaining comments from I39eaa7bef5e5c50b9b1a8833bec5e6da8cdf0d72
to fix error handling cases in mac_open.

Change-Id: Ica67df97442275e80cb6a33da5b431ab457bb6ea
CRs-Fixed: 2305354
This commit is contained in:
Vignesh Viswanathan 2018-08-29 14:11:36 +05:30 • committed by nshrivas
commit 56ee81f377
1 changed files with 12 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

23
core/mac/src/sys/legacy/src/system/src/mac_init_api.c
View file

@ -136,8 +136,7 @@ QDF_STATUS mac_open(struct wlan_objmgr_psoc *psoc, tHalHandle *pHalHandle,
status = wlan_objmgr_psoc_try_get_ref(psoc, WLAN_LEGACY_MAC_ID);
if (QDF_IS_STATUS_ERROR(status)) {
pe_err("PSOC get ref failure");
mac_free_context_buffer();
return QDF_STATUS_E_FAILURE;
goto free_mac_context;
}
p_mac->psoc = psoc;
@ -145,7 +144,7 @@ QDF_STATUS mac_open(struct wlan_objmgr_psoc *psoc, tHalHandle *pHalHandle,
if (!mlme_obj) {
pe_err("Failed to get MLME Obj");
status = QDF_STATUS_E_FAILURE;
goto fail;
goto release_psoc_ref;
}
p_mac->mlme_cfg = &mlme_obj->cfg;
@ -161,7 +160,7 @@ QDF_STATUS mac_open(struct wlan_objmgr_psoc *psoc, tHalHandle *pHalHandle,
/* Call routine to initialize CFG data structures */
if (QDF_STATUS_SUCCESS != cfg_init(p_mac)) {
status = QDF_STATUS_E_FAILURE;
goto fail;
goto release_psoc_ref;
}
sys_init_globals(p_mac);
@ -173,16 +172,18 @@ QDF_STATUS mac_open(struct wlan_objmgr_psoc *psoc, tHalHandle *pHalHandle,
p_mac->is_usr_cfg_amsdu_enabled = true;
status = pe_open(p_mac, cds_cfg);
if (QDF_STATUS_SUCCESS != status) {
pe_err("pe_open() failure");
cfg_de_init(p_mac);
goto fail;
}
if (QDF_IS_STATUS_SUCCESS(status))
return status;
return status;
fail:
pe_err("pe_open() failure");
cfg_de_init(p_mac);
release_psoc_ref:
wlan_objmgr_psoc_release_ref(psoc, WLAN_LEGACY_MAC_ID);
free_mac_context:
mac_free_context_buffer();
return status;
}