From 101889aaf8a46debf47930e45d96b55bb3f5144e Mon Sep 17 00:00:00 2001 From: Deepak Kumar Singh Date: Mon, 20 Apr 2020 16:49:58 +0530 Subject: [PATCH] net: qrtr: print error case for qrtr receive Print error code if there is failure in qrtr_recev Change-Id: Id08d4fc90994b2bc0b3c5de6c3bb7f1ae56e324f Signed-off-by: Deepak Kumar Singh --- net/qrtr/qrtr.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 2e7fb5518ec4..61309932fdb5 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -1741,16 +1741,20 @@ static int qrtr_recvmsg(struct socket *sock, struct msghdr *msg, struct qrtr_cb *cb; int copied, rc; + lock_sock(sk); - if (sock_flag(sk, SOCK_ZAPPED)) + if (sock_flag(sk, SOCK_ZAPPED)) { + release_sock(sk); + pr_err("%s: Invalid addr error\n", __func__); return -EADDRNOTAVAIL; - + } skb = skb_recv_datagram(sk, flags & ~MSG_DONTWAIT, flags & MSG_DONTWAIT, &rc); - if (!skb) + if (!skb) { + release_sock(sk); + pr_err("%s: Failed to get skb rc[%d]\n", __func__, rc); return rc; - - lock_sock(sk); + } cb = (struct qrtr_cb *)skb->cb; copied = skb->len; @@ -1760,8 +1764,10 @@ static int qrtr_recvmsg(struct socket *sock, struct msghdr *msg, } rc = skb_copy_datagram_msg(skb, 0, msg, copied); - if (rc < 0) + if (rc < 0) { + pr_err("%s: Failed to copy skb rc[%d]\n", __func__, rc); goto out; + } rc = copied; if (addr) {