From 59149d43ebc23dc68cb527533a1dcb10c1f94583 Mon Sep 17 00:00:00 2001 From: Vevek Venkatesan Date: Wed, 23 Dec 2020 20:08:11 +0530 Subject: [PATCH] qcacmn: fix error in NULL checking of rx_ring_history rx_ring_history is an array of pointers, address of pointer is always a non-NULL value, this always passed the NULL check, which leads to NULL pointer dereference, fixing the same. Change-Id: I401203a6f2a5930869cf4002ac0e714d3fdba62f CRs-Fixed: 2844038 --- dp/wifi3.0/dp_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dp/wifi3.0/dp_rx.c b/dp/wifi3.0/dp_rx.c index 72333e6ec40e..0271029be570 100644 --- a/dp/wifi3.0/dp_rx.c +++ b/dp/wifi3.0/dp_rx.c @@ -2122,7 +2122,7 @@ dp_rx_ring_record_entry(struct dp_soc *soc, uint8_t ring_num, struct hal_buf_info hbi; uint32_t idx; - if (qdf_unlikely(!&soc->rx_ring_history[ring_num])) + if (qdf_unlikely(!soc->rx_ring_history[ring_num])) return; hal_rx_reo_buf_paddr_get(ring_desc, &hbi);