diff --git a/umac/cmn_services/serialization/src/wlan_serialization_api.c b/umac/cmn_services/serialization/src/wlan_serialization_api.c index fffb843718d6..6cf61b7cf3cb 100644 --- a/umac/cmn_services/serialization/src/wlan_serialization_api.c +++ b/umac/cmn_services/serialization/src/wlan_serialization_api.c @@ -256,7 +256,9 @@ wlan_serialization_cancel_request( cmd.source = req->requestor; cmd.vdev = req->vdev; - ser_debug("Type %d id %d source %d", cmd.cmd_type, cmd.cmd_id, cmd.source); + ser_debug("Type %d id %d source %d req type %d queue type %d", + cmd.cmd_type, cmd.cmd_id, cmd.source, req->req_type, + req->queue_type); pdev = wlan_serialization_get_pdev_from_cmd(&cmd); if (!pdev) { ser_err("pdev is invalid"); @@ -313,8 +315,9 @@ void wlan_serialization_remove_cmd( if (ser_status != WLAN_SER_CMD_IN_ACTIVE_LIST) { if (ser_status != WLAN_SER_CMD_MARKED_FOR_ACTIVATION) - ser_debug("Can't dequeue requested id %d type %d requestor %d", - cmd.cmd_id, cmd.cmd_type, cmd_info->requestor); + ser_debug("Can't dequeue requested id %d type %d requestor %d", + cmd.cmd_id, cmd.cmd_type, + cmd_info->requestor); } } @@ -335,10 +338,8 @@ wlan_serialization_request(struct wlan_serialization_command *cmd) goto error; } status = wlan_serialization_validate_cmd(cmd->source, cmd->cmd_type); - if (QDF_IS_STATUS_ERROR(status)) { - ser_err("cmd is not valid"); + if (QDF_IS_STATUS_ERROR(status)) goto error; - } psoc = wlan_serialization_get_psoc_from_cmd(cmd); if (!psoc) { diff --git a/umac/cmn_services/serialization/src/wlan_serialization_internal.c b/umac/cmn_services/serialization/src/wlan_serialization_internal.c index d729a58f4289..27c10f150fcc 100644 --- a/umac/cmn_services/serialization/src/wlan_serialization_internal.c +++ b/umac/cmn_services/serialization/src/wlan_serialization_internal.c @@ -463,9 +463,9 @@ wlan_serialization_dequeue_cmd(struct wlan_serialization_command *cmd, pdev_queue = wlan_serialization_get_pdev_queue_obj( ser_pdev_obj, cmd->cmd_type); - ser_debug("Type %d id %d high_priority %d blocking %d", - cmd->cmd_type, cmd->cmd_id, cmd->is_high_priority, - cmd->is_blocking); + ser_debug("Type %d id %d blocking %d reason %d active %d", + cmd->cmd_type, cmd->cmd_id, cmd->is_blocking, + ser_reason, active_cmd); wlan_serialization_acquire_lock(&pdev_queue->pdev_queue_lock); diff --git a/umac/cmn_services/serialization/src/wlan_serialization_utils.c b/umac/cmn_services/serialization/src/wlan_serialization_utils.c index 66ad72801014..4ec739408f03 100644 --- a/umac/cmn_services/serialization/src/wlan_serialization_utils.c +++ b/umac/cmn_services/serialization/src/wlan_serialization_utils.c @@ -247,7 +247,7 @@ QDF_STATUS wlan_serialization_validate_cmdtype( enum wlan_serialization_cmd_type cmd_type) { if (cmd_type < 0 || cmd_type >= WLAN_SER_CMD_MAX) { - ser_err("Invalid cmd or comp passed"); + ser_err("Invalid cmd %d passed", cmd_type); return QDF_STATUS_E_INVAL; } @@ -260,9 +260,8 @@ QDF_STATUS wlan_serialization_validate_cmd( { QDF_STATUS status = QDF_STATUS_E_INVAL; - if (cmd_type < 0 || comp_id < 0 || - cmd_type >= WLAN_SER_CMD_MAX || - comp_id >= WLAN_UMAC_COMP_ID_MAX) { + if (cmd_type < 0 || comp_id < 0 || cmd_type >= WLAN_SER_CMD_MAX || + comp_id >= WLAN_UMAC_COMP_ID_MAX) { ser_err("Invalid cmd or comp passed comp %d type %d", comp_id, cmd_type); goto error;