From 5ba2743676a0eb254ffef322c7be7fc59ad3b1b4 Mon Sep 17 00:00:00 2001 From: Arun Kumar Khandavalli Date: Mon, 20 Jan 2020 11:47:44 +0530 Subject: [PATCH] qcacld-3.0: Selectively reduce the pe layer logs Selectively reduce pe layer logs loglevel from info to debug. Change-Id: I187040fe2862253b2c93b32ef3c6cd247a4f0b04 CRS-Fixed: 2607090 --- core/mac/src/pe/lim/lim_api.c | 2 +- core/mac/src/pe/lim/lim_ft.c | 2 +- .../src/pe/lim/lim_process_assoc_req_frame.c | 4 +-- .../src/pe/lim/lim_process_assoc_rsp_frame.c | 13 ++++---- core/mac/src/pe/lim/lim_process_auth_frame.c | 14 ++++---- core/mac/src/pe/lim/lim_process_fils.c | 4 +-- .../src/pe/lim/lim_process_mlm_rsp_messages.c | 2 +- .../src/pe/lim/lim_process_sme_req_messages.c | 2 +- core/mac/src/pe/lim/lim_process_tdls.c | 4 +-- .../src/pe/lim/lim_send_management_frames.c | 32 +++++++++++-------- core/mac/src/pe/lim/lim_session.c | 2 +- core/mac/src/pe/lim/lim_timer_utils.c | 8 ++--- core/mac/src/pe/lim/lim_utils.c | 4 +-- 13 files changed, 50 insertions(+), 43 deletions(-) diff --git a/core/mac/src/pe/lim/lim_api.c b/core/mac/src/pe/lim/lim_api.c index e845edb58900..e61d6cdb829c 100644 --- a/core/mac/src/pe/lim/lim_api.c +++ b/core/mac/src/pe/lim/lim_api.c @@ -2804,7 +2804,7 @@ QDF_STATUS lim_update_ext_cap_ie(struct mac_context *mac_ctx, uint8_t *ie_data, populate_dot11f_twt_extended_caps(mac_ctx, session, &driver_ext_cap); else - pe_err("Session NULL, cannot set TWT caps"); + pe_debug("Session NULL, cannot set TWT caps"); local_ie_buf[*local_ie_len + 1] = driver_ext_cap.num_bytes; diff --git a/core/mac/src/pe/lim/lim_ft.c b/core/mac/src/pe/lim/lim_ft.c index a42d982ac43d..a091fe15fc13 100644 --- a/core/mac/src/pe/lim/lim_ft.c +++ b/core/mac/src/pe/lim/lim_ft.c @@ -71,7 +71,7 @@ void lim_ft_cleanup(struct mac_context *mac, struct pe_session *pe_session) /* Nothing to be done if the session is not in STA mode */ if (!LIM_IS_STA_ROLE(pe_session)) { - pe_err("pe_session is not in STA mode"); + pe_debug("pe_session is not in STA mode"); return; } diff --git a/core/mac/src/pe/lim/lim_process_assoc_req_frame.c b/core/mac/src/pe/lim/lim_process_assoc_req_frame.c index d0853cd2282e..febdd87aa907 100644 --- a/core/mac/src/pe/lim/lim_process_assoc_req_frame.c +++ b/core/mac/src/pe/lim/lim_process_assoc_req_frame.c @@ -962,8 +962,8 @@ static bool lim_check_wpa_rsn_ie(struct pe_session *session, */ qdf_mem_zero((uint8_t *) &dot11f_ie_rsn, sizeof(dot11f_ie_rsn)); qdf_mem_zero((uint8_t *) &dot11f_ie_wpa, sizeof(dot11f_ie_wpa)); - pe_err("RSN enabled auth, Re/Assoc req from STA: " - QDF_MAC_ADDR_STR, QDF_MAC_ADDR_ARRAY(hdr->sa)); + pe_debug("RSN enabled auth, Re/Assoc req from STA: " + QDF_MAC_ADDR_STR, QDF_MAC_ADDR_ARRAY(hdr->sa)); if (assoc_req->rsnPresent) { if (!(assoc_req->rsn.length)) { diff --git a/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c b/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c index a67dafcbd4b3..ce68d57bf29a 100644 --- a/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c +++ b/core/mac/src/pe/lim/lim_process_assoc_rsp_frame.c @@ -604,12 +604,13 @@ lim_process_assoc_rsp_frame(struct mac_context *mac_ctx, return; } - pe_debug("received Re/Assoc: %d resp on sessionid: %d systemrole: %d" - " and mlmstate: %d RSSI: %d from "QDF_MAC_ADDR_STR, subtype, - session_entry->peSessionId, GET_LIM_SYSTEM_ROLE(session_entry), - session_entry->limMlmState, - (uint) abs((int8_t) WMA_GET_RX_RSSI_NORMALIZED(rx_pkt_info)), - QDF_MAC_ADDR_ARRAY(hdr->sa)); + pe_nofl_info("Assoc RX %d vid %d sys role %d" + " lim state %d rssi %d from "QDF_MAC_ADDR_STR, subtype, + session_entry->peSessionId, + GET_LIM_SYSTEM_ROLE(session_entry), + session_entry->limMlmState, + WMA_GET_RX_RSSI_NORMALIZED(rx_pkt_info), + QDF_MAC_ADDR_ARRAY(hdr->sa)); beacon = qdf_mem_malloc(sizeof(tSchBeaconStruct)); if (!beacon) diff --git a/core/mac/src/pe/lim/lim_process_auth_frame.c b/core/mac/src/pe/lim/lim_process_auth_frame.c index d00066e0ffca..8405136dea11 100644 --- a/core/mac/src/pe/lim/lim_process_auth_frame.c +++ b/core/mac/src/pe/lim/lim_process_auth_frame.c @@ -358,8 +358,9 @@ static void lim_process_sae_auth_frame(struct mac_context *mac_ctx, body_ptr = WMA_GET_RX_MPDU_DATA(rx_pkt_info); frame_len = WMA_GET_RX_PAYLOAD_LEN(rx_pkt_info); - pe_debug("Received SAE Auth frame type %d subtype %d", - mac_hdr->fc.type, mac_hdr->fc.subType); + pe_nofl_info("SAE Auth RX type %d subtype %d from %pM", + mac_hdr->fc.type, mac_hdr->fc.subType, + mac_hdr->sa); if (LIM_IS_STA_ROLE(pe_session) && pe_session->limMlmState != eLIM_MLM_WT_SAE_AUTH_STATE) @@ -1249,10 +1250,11 @@ lim_process_auth_frame(struct mac_context *mac_ctx, uint8_t *rx_pkt_info, curr_seq_num = (mac_hdr->seqControl.seqNumHi << 4) | (mac_hdr->seqControl.seqNumLo); - pe_debug("Sessionid: %d System role: %d limMlmState: %d: Auth response Received BSSID: "QDF_MAC_ADDR_STR" RSSI: %d", - pe_session->peSessionId, GET_LIM_SYSTEM_ROLE(pe_session), - pe_session->limMlmState, QDF_MAC_ADDR_ARRAY(mac_hdr->bssId), - (uint) abs((int8_t) WMA_GET_RX_RSSI_NORMALIZED(rx_pkt_info))); + pe_nofl_info("vid %d sys role %d lim_state %d Auth RX from "QDF_MAC_ADDR_STR" rssi %d", + pe_session->peSessionId, GET_LIM_SYSTEM_ROLE(pe_session), + pe_session->limMlmState, + QDF_MAC_ADDR_ARRAY(mac_hdr->bssId), + WMA_GET_RX_RSSI_NORMALIZED(rx_pkt_info)); if (pe_session->prev_auth_seq_num == curr_seq_num && mac_hdr->fc.retry) { diff --git a/core/mac/src/pe/lim/lim_process_fils.c b/core/mac/src/pe/lim/lim_process_fils.c index e3e4cfa4d3b2..e73823de47c3 100644 --- a/core/mac/src/pe/lim/lim_process_fils.c +++ b/core/mac/src/pe/lim/lim_process_fils.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2017-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -42,7 +42,7 @@ static void lim_fils_data_dump(char *type, uint8_t *data, uint32_t len) QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, ("%s : length %d"), type, len); - qdf_trace_hex_dump(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, data, len); + qdf_trace_hex_dump(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, data, len); } #else static void lim_fils_data_dump(char *type, uint8_t *data, uint32_t len) diff --git a/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c b/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c index 94395d30cd71..0fd1babe4cc5 100644 --- a/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c +++ b/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c @@ -1760,7 +1760,7 @@ void lim_process_ap_mlm_del_sta_rsp(struct mac_context *mac_ctx, goto end; } - pe_warn("AP received the DEL_STA_RSP for assocID: %X sta mac " + pe_debug("AP received the DEL_STA_RSP for assocID: %X sta mac " QDF_MAC_ADDR_STR, del_sta_params->assocId, QDF_MAC_ADDR_ARRAY(sta_ds->staAddr)); if ((eLIM_MLM_WT_DEL_STA_RSP_STATE != sta_ds->mlmStaContext.mlmState) && diff --git a/core/mac/src/pe/lim/lim_process_sme_req_messages.c b/core/mac/src/pe/lim/lim_process_sme_req_messages.c index b85ea22ef151..a19e6c5a5e9b 100644 --- a/core/mac/src/pe/lim/lim_process_sme_req_messages.c +++ b/core/mac/src/pe/lim/lim_process_sme_req_messages.c @@ -462,7 +462,7 @@ lim_configure_ap_start_bss_session(struct mac_context *mac_ctx, session->sap_dot11mc = sme_start_bss_req->sap_dot11mc; session->vendor_vht_sap = sme_start_bss_req->vendor_vht_sap; - pe_info("vendor_vht_sap %d", session->vendor_vht_sap); + pe_debug("vendor_vht_sap %d", session->vendor_vht_sap); lim_get_short_slot_from_phy_mode(mac_ctx, session, session->gLimPhyMode, &session->shortSlotTimeSupported); session->isCoalesingInIBSSAllowed = diff --git a/core/mac/src/pe/lim/lim_process_tdls.c b/core/mac/src/pe/lim/lim_process_tdls.c index 1c037203c6e0..59c54008f309 100644 --- a/core/mac/src/pe/lim/lim_process_tdls.c +++ b/core/mac/src/pe/lim/lim_process_tdls.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2012-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -3219,7 +3219,7 @@ QDF_STATUS lim_process_sme_del_all_tdls_peers(struct mac_context *p_mac, session_entry = pe_find_session_by_bssid(p_mac, msg->bssid.bytes, &session_id); if (!session_entry) { - pe_err("NULL pe_session"); + pe_debug("NULL pe_session"); return QDF_STATUS_E_FAILURE; } diff --git a/core/mac/src/pe/lim/lim_send_management_frames.c b/core/mac/src/pe/lim/lim_send_management_frames.c index 8f531b6b0841..eb3a2a0528ea 100644 --- a/core/mac/src/pe/lim/lim_send_management_frames.c +++ b/core/mac/src/pe/lim/lim_send_management_frames.c @@ -1739,7 +1739,10 @@ static QDF_STATUS lim_assoc_tx_complete_cnf(void *context, uint16_t reason_code; struct mac_context *mac_ctx = (struct mac_context *)context; - pe_debug("tx_complete= %d", tx_complete); + pe_nofl_info("Assoc TX %s", + (tx_complete == WMI_MGMT_TX_COMP_TYPE_COMPLETE_OK) ? + "success" : "fail"); + if (tx_complete == WMI_MGMT_TX_COMP_TYPE_COMPLETE_OK) { assoc_ack_status = ACKED; reason_code = QDF_STATUS_SUCCESS; @@ -2423,7 +2426,10 @@ lim_send_assoc_req_mgmt_frame(struct mac_context *mac_ctx, MTRACE(qdf_trace(QDF_MODULE_ID_PE, TRACE_CODE_TX_MGMT, pe_session->peSessionId, mac_hdr->fc.subType)); - pe_debug("Sending Association Request length %d to ", bytes); + pe_nofl_info("vid %d Assoc TX to %pM seq num %d", + pe_session->vdev_id, pe_session->bssId, + mac_ctx->mgmtSeqNum); + min_rid = lim_get_min_session_txrate(pe_session); lim_diag_event_report(mac_ctx, WLAN_PE_DIAG_ASSOC_START_EVENT, pe_session, QDF_STATUS_SUCCESS, QDF_STATUS_SUCCESS); @@ -2541,9 +2547,9 @@ static QDF_STATUS lim_auth_tx_complete_cnf(void *context, uint16_t auth_ack_status; uint16_t reason_code; - pe_debug("tx_complete = %d %s", tx_complete, - (tx_complete == WMI_MGMT_TX_COMP_TYPE_COMPLETE_OK) ? - "success" : "fail"); + pe_nofl_info("Auth TX %s", + (tx_complete == WMI_MGMT_TX_COMP_TYPE_COMPLETE_OK) ? + "success" : "fail"); if (tx_complete == WMI_MGMT_TX_COMP_TYPE_COMPLETE_OK) { mac_ctx->auth_ack_status = LIM_AUTH_ACK_RCD_SUCCESS; auth_ack_status = ACKED; @@ -2810,9 +2816,8 @@ alloc_packet: qdf_mem_copy(body, auth_frame->challengeText, SIR_MAC_SAP_AUTH_CHALLENGE_LENGTH); body += SIR_MAC_SAP_AUTH_CHALLENGE_LENGTH; - body_len -= SIR_MAC_SAP_AUTH_CHALLENGE_LENGTH + - SIR_MAC_CHALLENGE_ID_LEN; + SIR_MAC_CHALLENGE_ID_LEN; } } @@ -2851,13 +2856,12 @@ alloc_packet: lim_add_fils_data_to_auth_frame(session, body); } - pe_debug("*** Sending Auth seq# %d status %d (%d) to " - QDF_MAC_ADDR_STR, - auth_frame->authTransactionSeqNumber, - auth_frame->authStatusCode, - (auth_frame->authStatusCode == - eSIR_MAC_SUCCESS_STATUS), - QDF_MAC_ADDR_ARRAY(mac_hdr->da)); + pe_nofl_info("Auth TX seq %d seq num %d status %d to " + QDF_MAC_ADDR_STR, + auth_frame->authTransactionSeqNumber, + mac_ctx->mgmtSeqNum, + auth_frame->authStatusCode, + QDF_MAC_ADDR_ARRAY(mac_hdr->da)); } QDF_TRACE_HEX_DUMP(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, diff --git a/core/mac/src/pe/lim/lim_session.c b/core/mac/src/pe/lim/lim_session.c index 2b0320582c39..ec6fa168185a 100644 --- a/core/mac/src/pe/lim/lim_session.c +++ b/core/mac/src/pe/lim/lim_session.c @@ -817,7 +817,7 @@ void pe_delete_session(struct mac_context *mac_ctx, struct pe_session *session) struct wlan_objmgr_vdev *vdev; if (!session || (session && !session->valid)) { - pe_err("session already deleted or not valid"); + pe_debug("session already deleted or not valid"); return; } diff --git a/core/mac/src/pe/lim/lim_timer_utils.c b/core/mac/src/pe/lim/lim_timer_utils.c index b4679602a886..3c8447eeca85 100644 --- a/core/mac/src/pe/lim/lim_timer_utils.c +++ b/core/mac/src/pe/lim/lim_timer_utils.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2011-2019 The Linux Foundation. All rights reserved. + * Copyright (c) 2011-2020 The Linux Foundation. All rights reserved. * * Permission to use, copy, modify, and/or distribute this software for * any purpose with or without fee is hereby granted, provided that the @@ -600,9 +600,9 @@ void lim_deactivate_and_change_timer(struct mac_context *mac, uint32_t timerId) mac->lim.lim_timers. g_lim_periodic_auth_retry_timer.sessionId); if (!session_entry) { - pe_err("session does not exist for given SessionId : %d", - mac->lim.lim_timers. - g_lim_periodic_auth_retry_timer.sessionId); + pe_debug("session does not exist for given SessionId : %d", + mac->lim.lim_timers. + g_lim_periodic_auth_retry_timer.sessionId); break; } /* 3/5 of the beacon interval */ diff --git a/core/mac/src/pe/lim/lim_utils.c b/core/mac/src/pe/lim/lim_utils.c index 63d138290fac..70b8b15dd1f0 100644 --- a/core/mac/src/pe/lim/lim_utils.c +++ b/core/mac/src/pe/lim/lim_utils.c @@ -869,7 +869,7 @@ void lim_handle_update_olbc_cache(struct mac_context *mac_ctx) struct pe_session *pe_session = lim_is_ap_session_active(mac_ctx); if (!pe_session) { - pe_err(" Session not found"); + pe_debug(" Session not found"); return; } @@ -7973,7 +7973,7 @@ QDF_STATUS lim_sta_mlme_vdev_stop_send(struct vdev_mlme_obj *vdev_mlme, } connection_fail = mlme_is_connection_fail(vdev_mlme->vdev); - pe_info("Send vdev stop, connection_fail %d", connection_fail); + pe_debug("Send vdev stop, connection_fail %d", connection_fail); if (connection_fail) { assoc_type = mlme_get_assoc_type(vdev_mlme->vdev); switch (assoc_type) {