From 5c0d7514149bb455f3eead746d963e5b5d107422 Mon Sep 17 00:00:00 2001 From: Lin Bai Date: Thu, 15 Nov 2018 15:48:10 +0800 Subject: [PATCH] qcacmn: Typecast variable to same type before comparison Typecast 'rowsize' to qdf_size_t, to avoid compiler error 'comparison of distinct pointer types lacks a cast'. Change-Id: I29e05a1f0d165accf3bebefc0af2b9f97cac0f5d CRs-Fixed: 2350601 --- qdf/linux/src/qdf_debugfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qdf/linux/src/qdf_debugfs.c b/qdf/linux/src/qdf_debugfs.c index 57895d1da0e3..f590a87508b6 100644 --- a/qdf/linux/src/qdf_debugfs.c +++ b/qdf/linux/src/qdf_debugfs.c @@ -180,14 +180,14 @@ void qdf_debugfs_hexdump(qdf_debugfs_file_t file, const uint8_t *buf, qdf_size_t len, int rowsize, int groupsize) { char *dst; - size_t dstlen, readlen; + size_t dstlen, readlen, remaining = len; int prefix = 0; size_t commitlen; - while (len > 0 && (file->size > file->count)) { + while (remaining > 0 && (file->size > file->count)) { seq_printf(file, "%.8x: ", prefix); - readlen = min(len, rowsize); + readlen = qdf_min(remaining, (qdf_size_t)rowsize); dstlen = seq_get_buf(file, &dst); hex_dump_to_buffer(buf, readlen, rowsize, groupsize, dst, dstlen, false); @@ -195,7 +195,7 @@ void qdf_debugfs_hexdump(qdf_debugfs_file_t file, const uint8_t *buf, seq_commit(file, commitlen); seq_putc(file, '\n'); - len = (len > rowsize) ? len - rowsize : 0; + remaining = (remaining > rowsize) ? remaining - rowsize : 0; buf += readlen; prefix += rowsize; }