From 5d442d9b6872b99341f1e87afd3d4e2de6a3f93e Mon Sep 17 00:00:00 2001 From: Yue Ma Date: Thu, 10 Dec 2020 16:36:53 -0800 Subject: [PATCH] cnss2: Minor enhancements for the driver Use default RAM dump size if it is not defined in device tree node. Also print MSI 64-bit address (high and low 32-bit) for debug purpose. Change-Id: Iff382862e5a04ce995f2ec3bfeffaf7a1f6b78ee Signed-off-by: Yue Ma --- drivers/net/wireless/cnss2/pci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/cnss2/pci.c b/drivers/net/wireless/cnss2/pci.c index 2a981008cc3e..e2bbf59a4b65 100644 --- a/drivers/net/wireless/cnss2/pci.c +++ b/drivers/net/wireless/cnss2/pci.c @@ -57,6 +57,7 @@ #define EMULATION_HW 0 #endif +#define RAMDUMP_SIZE_DEFAULT 0x420000 #define DEVICE_RDDM_COOKIE 0xCAFECACE static DEFINE_SPINLOCK(pci_link_down_lock); @@ -4080,13 +4081,16 @@ void cnss_get_msi_address(struct device *dev, u32 *msi_addr_low, &control); pci_read_config_dword(pci_dev, pci_dev->msi_cap + PCI_MSI_ADDRESS_LO, msi_addr_low); - /*return msi high addr only when device support 64 BIT MSI */ + /* Return MSI high address only when device supports 64-bit MSI */ if (control & PCI_MSI_FLAGS_64BIT) pci_read_config_dword(pci_dev, pci_dev->msi_cap + PCI_MSI_ADDRESS_HI, msi_addr_high); else *msi_addr_high = 0; + + cnss_pr_dbg("Get MSI low addr = 0x%x, high addr = 0x%x\n", + *msi_addr_low, *msi_addr_high); } EXPORT_SYMBOL(cnss_get_msi_address); @@ -4947,6 +4951,8 @@ static int cnss_pci_register_mhi(struct cnss_pci_data *pci_priv) mhi_ctrl->bw_scale = cnss_mhi_bw_scale; mhi_ctrl->rddm_size = pci_priv->plat_priv->ramdump_info_v2.ramdump_size; + if (!mhi_ctrl->rddm_size) + mhi_ctrl->rddm_size = RAMDUMP_SIZE_DEFAULT; mhi_ctrl->sbl_size = SZ_512K; mhi_ctrl->seg_len = SZ_512K; mhi_ctrl->fbc_download = true;