From 5d4c6f2f172da71ddf3421050e3182fc29e271e7 Mon Sep 17 00:00:00 2001 From: Alok Kumar Date: Mon, 24 Jun 2019 16:31:59 +0530 Subject: [PATCH] qcacmn: Avoid NULL pointer dereference of pointer 'pPacket' Pointer 'pPacket' returned from call to the function 'htc_packet_dequeue' may be NULL. Add a NULL check for pPacket before dereferencing it. Change-Id: I1ecb82cce0fc00877b3ec2de2676027dde261186 CRs-Fixed: 2478206 --- htc/htc_send.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/htc/htc_send.c b/htc/htc_send.c index 3ac12954a6d8..2a7b81c6e39b 100644 --- a/htc/htc_send.c +++ b/htc/htc_send.c @@ -1068,8 +1068,10 @@ static enum HTC_SEND_QUEUE_RESULT htc_try_send(HTC_TARGET *target, /* pop off caller's queue */ pPacket = htc_packet_dequeue(pCallersSendQueue); A_ASSERT(pPacket); - /* insert into local queue */ - HTC_PACKET_ENQUEUE(&sendQueue, pPacket); + if (pPacket) + /* insert into local queue */ + HTC_PACKET_ENQUEUE(&sendQueue, + pPacket); } /* the caller's queue has all the packets that won't fit