From 5d8d7332fc05e08a5c71ec0967a3963115885389 Mon Sep 17 00:00:00 2001 From: Abhishek Singh Date: Thu, 10 Aug 2017 15:15:24 +0530 Subject: [PATCH] qcacld-3.0: Reduce the log spam in Kmsg Move the logs to appropriate log levels to reduce the log spam in kmsg Change-Id: I2138de8f2be2e432ba84ee0615c14946da228fc9 CRs-Fixed: 1093093 --- core/mac/src/pe/lim/lim_process_auth_frame.c | 6 ++-- .../src/pe/lim/lim_process_message_queue.c | 28 +++++++++---------- .../src/pe/lim/lim_process_mlm_rsp_messages.c | 6 ++-- .../src/pe/lim/lim_process_sme_req_messages.c | 10 +++---- .../src/pe/lim/lim_send_management_frames.c | 2 +- core/mac/src/pe/lim/lim_utils.c | 6 ++-- .../src/sys/legacy/src/utils/src/parser_api.c | 4 --- core/sme/src/common/sme_api.c | 4 +-- 8 files changed, 30 insertions(+), 36 deletions(-) diff --git a/core/mac/src/pe/lim/lim_process_auth_frame.c b/core/mac/src/pe/lim/lim_process_auth_frame.c index 174c7bdb8989..8bb438e261fe 100644 --- a/core/mac/src/pe/lim/lim_process_auth_frame.c +++ b/core/mac/src/pe/lim/lim_process_auth_frame.c @@ -167,7 +167,7 @@ static void lim_process_auth_shared_system_algo(tpAniSirGlobal mac_ctx, pe_debug("Alloc new data: %p id: %d peer ", auth_node, auth_node->authNodeIdx); - lim_print_mac_addr(mac_ctx, mac_hdr->sa, LOG1); + lim_print_mac_addr(mac_ctx, mac_hdr->sa, LOGD); /* / Create and activate Auth Response timer */ if (tx_timer_change_context(&auth_node->timer, auth_node->authNodeIdx) != TX_SUCCESS) { @@ -554,7 +554,7 @@ static void lim_process_auth_frame_type2(tpAniSirGlobal mac_ctx, */ pe_debug("rx Auth frm2 from peer in state: %d addr", pe_session->limMlmState); - lim_print_mac_addr(mac_ctx, mac_hdr->sa, LOG1); + lim_print_mac_addr(mac_ctx, mac_hdr->sa, LOGD); } return; } @@ -1539,8 +1539,6 @@ tSirRetStatus lim_process_auth_frame_no_session(tpAniSirGlobal pMac, uint8_t *pB true; } - pe_debug("Pre-Auth response received from neighbor"); - pe_debug("Pre-Auth done state"); /* Stopping timer now, that we have our unicast from the AP */ /* of our choice. */ lim_deactivate_and_change_timer(pMac, eLIM_FT_PREAUTH_RSP_TIMER); diff --git a/core/mac/src/pe/lim/lim_process_message_queue.c b/core/mac/src/pe/lim/lim_process_message_queue.c index c5ea380978b8..ce20dbc8886c 100644 --- a/core/mac/src/pe/lim/lim_process_message_queue.c +++ b/core/mac/src/pe/lim/lim_process_message_queue.c @@ -728,12 +728,12 @@ static void lim_handle_unknown_a2_index_frames(tpAniSirGlobal mac_ctx, mac_hdr = WMA_GET_RX_MPDUHEADER3A(rx_pkt_buffer); if (lim_is_group_addr(mac_hdr->addr2)) { - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO_HIGH, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, FL("Ignoring A2 Invalid Packet received for MC/BC:")); - lim_print_mac_addr(mac_ctx, mac_hdr->addr2, LOG2); + lim_print_mac_addr(mac_ctx, mac_hdr->addr2, LOGD); return; } - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, FL("type=0x%x, subtype=0x%x"), mac_hdr->fc.type, mac_hdr->fc.subType); /* Currently only following type and subtype are handled. @@ -793,7 +793,7 @@ lim_check_mgmt_registered_frames(tpAniSirGlobal mac_ctx, uint8_t *buff_desc, if ((type == SIR_MAC_MGMT_FRAME) && (fc.type == SIR_MAC_MGMT_FRAME) && (sub_type == SIR_MAC_MGMT_RESERVED15)) { - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO_HIGH, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, FL ("rcvd frm match for SIR_MAC_MGMT_RESERVED15")); match = true; @@ -825,7 +825,7 @@ lim_check_mgmt_registered_frames(tpAniSirGlobal mac_ctx, uint8_t *buff_desc, } if (match) { - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, FL("rcvd frame match with registered frame params")); /* Indicate this to SME */ lim_send_sme_mgmt_frame_ind(mac_ctx, hdr->fc.subType, @@ -942,7 +942,7 @@ lim_handle80211_frames(tpAniSirGlobal pMac, struct scheduler_msg *limMsg, pe_debug("ProtVersion %d, Type %d, Subtype %d rateIndex=%d", fc.protVer, fc.type, fc.subType, WMA_GET_RX_MAC_RATE_IDX(pRxPacketInfo)); - lim_print_mac_addr(pMac, pHdr->bssId, LOG1); + lim_print_mac_addr(pMac, pHdr->bssId, LOGD); if (lim_process_auth_frame_no_session (pMac, pRxPacketInfo, limMsg->bodyptr) == eSIR_SUCCESS) { @@ -1198,20 +1198,20 @@ static void lim_process_sme_obss_scan_ind(tpAniSirGlobal mac_ctx, session = pe_find_session_by_bssid(mac_ctx, ht40_scanind->mac_addr.bytes, &session_id); if (session == NULL) { - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, "OBSS Scan not started: session id is NULL"); return; } if (session->htSupportedChannelWidthSet == WNI_CFG_CHANNEL_BONDING_MODE_ENABLE) { - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, "OBSS Scan Start Req: session id %d" "htSupportedChannelWidthSet %d", session->peSessionId, session->htSupportedChannelWidthSet); lim_send_ht40_obss_scanind(mac_ctx, session); } else { - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, "OBSS Scan not started: channel width - %d session %d", session->htSupportedChannelWidthSet, session->peSessionId); @@ -1360,7 +1360,7 @@ static void lim_process_messages(tpAniSirGlobal mac_ctx, lim_handle80211_frames(mac_ctx, &new_msg, &defer_msg); if (defer_msg == true) { - QDF_TRACE(QDF_MODULE_ID_PE, LOG1, + QDF_TRACE(QDF_MODULE_ID_PE, LOGD, FL("Defer Msg type=%x"), msg->type); if (lim_defer_msg(mac_ctx, msg) != TX_SUCCESS) { QDF_TRACE(QDF_MODULE_ID_PE, LOGE, @@ -1522,7 +1522,7 @@ static void lim_process_messages(tpAniSirGlobal mac_ctx, session_entry = pe_find_session_by_sta_id(mac_ctx, tdls_ind->staIdx, &session_id); if (session_entry == NULL) { - pe_err("No session exist for given bssId"); + pe_debug("No session exist for given bssId"); qdf_mem_free(msg->bodyptr); msg->bodyptr = NULL; return; @@ -1674,7 +1674,7 @@ static void lim_process_messages(tpAniSirGlobal mac_ctx, case SIR_HAL_TDLS_SHOULD_TEARDOWN: case SIR_HAL_TDLS_PEER_DISCONNECTED: case SIR_HAL_TDLS_CONNECTION_TRACKER_NOTIFICATION: - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, ("%s received tdls event: 0x%x"), __func__, msg->type); lim_send_sme_tdls_event_notify(mac_ctx, msg->type, (void *)msg->bodyptr); @@ -2176,10 +2176,10 @@ void lim_log_session_states(tpAniSirGlobal mac_ctx) for (i = 0; i < mac_ctx->lim.maxBssId; i++) { if (mac_ctx->lim.gpSession[i].valid) { - QDF_TRACE(QDF_MODULE_ID_PE, LOG1, + QDF_TRACE(QDF_MODULE_ID_PE, LOGD, FL("sysRole(%d) Session (%d)"), mac_ctx->lim.gLimSystemRole, i); - QDF_TRACE(QDF_MODULE_ID_PE, LOG1, + QDF_TRACE(QDF_MODULE_ID_PE, LOGD, FL("SME: Curr %s,Prev %s,MLM: Curr %s,Prev %s"), lim_sme_state_str( mac_ctx->lim.gpSession[i].limSmeState), diff --git a/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c b/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c index 361d7876d842..2aeee5534cd2 100644 --- a/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c +++ b/core/mac/src/pe/lim/lim_process_mlm_rsp_messages.c @@ -250,7 +250,7 @@ void lim_process_mlm_start_cnf(tpAniSirGlobal pMac, uint32_t *pMsgBuf) } if (send_bcon_ind) { /* Configure beacon and send beacons to HAL */ - QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_INFO, + QDF_TRACE(QDF_MODULE_ID_PE, QDF_TRACE_LEVEL_DEBUG, FL("Start Beacon with ssid %s Ch %d"), psessionEntry->ssId.ssId, psessionEntry->currentOperChannel); @@ -1830,7 +1830,7 @@ void lim_process_ap_mlm_del_sta_rsp(tpAniSirGlobal mac_ctx, pe_debug("Deleted STA AssocID %d staId %d MAC", sta_ds->assocId, sta_ds->staIndex); - lim_print_mac_addr(mac_ctx, sta_ds->staAddr, LOG1); + lim_print_mac_addr(mac_ctx, sta_ds->staAddr, LOGD); if (eLIM_MLM_WT_ASSOC_DEL_STA_RSP_STATE == sta_ds->mlmStaContext.mlmState) { qdf_mem_free(del_sta_params); @@ -1984,7 +1984,7 @@ void lim_process_ap_mlm_add_sta_rsp(tpAniSirGlobal pMac, pStaDs->mlmStaContext.mlmState = eLIM_MLM_WT_ASSOC_CNF_STATE; pe_debug("AddStaRsp Success.STA AssocID %d staId %d MAC", pStaDs->assocId, pStaDs->staIndex); - lim_print_mac_addr(pMac, pStaDs->staAddr, LOG1); + lim_print_mac_addr(pMac, pStaDs->staAddr, LOGD); /* For BTAMP-AP, the flow sequence shall be: * 1) PE sends eWNI_SME_ASSOC_IND to SME diff --git a/core/mac/src/pe/lim/lim_process_sme_req_messages.c b/core/mac/src/pe/lim/lim_process_sme_req_messages.c index f8b3128f3b26..f0d8d75c092c 100644 --- a/core/mac/src/pe/lim/lim_process_sme_req_messages.c +++ b/core/mac/src/pe/lim/lim_process_sme_req_messages.c @@ -3445,7 +3445,7 @@ void __lim_process_sme_assoc_cnf_new(tpAniSirGlobal mac_ctx, uint32_t msg_type, if (sta_ds == NULL) { pe_err("Rcvd invalid msg %X due to no STA ctx, aid %d, peer", msg_type, assoc_cnf.aid); - lim_print_mac_addr(mac_ctx, assoc_cnf.peer_macaddr.bytes, LOG1); + lim_print_mac_addr(mac_ctx, assoc_cnf.peer_macaddr.bytes, LOGE); /* * send a DISASSOC_IND message to WSM to make sure @@ -3464,7 +3464,7 @@ void __lim_process_sme_assoc_cnf_new(tpAniSirGlobal mac_ctx, uint32_t msg_type, QDF_MAC_ADDR_SIZE)) { pe_debug("peerMacAddr mismatched for aid %d, peer ", assoc_cnf.aid); - lim_print_mac_addr(mac_ctx, assoc_cnf.peer_macaddr.bytes, LOG1); + lim_print_mac_addr(mac_ctx, assoc_cnf.peer_macaddr.bytes, LOGD); goto end; } @@ -3476,7 +3476,7 @@ void __lim_process_sme_assoc_cnf_new(tpAniSirGlobal mac_ctx, uint32_t msg_type, pe_debug("not in MLM_WT_ASSOC_CNF_STATE, for aid %d, peer" "StaD mlmState: %d", assoc_cnf.aid, sta_ds->mlmStaContext.mlmState); - lim_print_mac_addr(mac_ctx, assoc_cnf.peer_macaddr.bytes, LOG1); + lim_print_mac_addr(mac_ctx, assoc_cnf.peer_macaddr.bytes, LOGD); goto end; } /* @@ -3642,13 +3642,13 @@ static void __lim_process_sme_addts_req(tpAniSirGlobal pMac, uint32_t *pMsgBuf) /* ship out the message now */ lim_send_addts_req_action_frame(pMac, peerMac, &pSirAddts->req, psessionEntry); - pe_debug("Sent ADDTS request"); + pe_err("Sent ADDTS request"); /* start a timer to wait for the response */ if (pSirAddts->timeout) timeout = pSirAddts->timeout; else if (wlan_cfg_get_int(pMac, WNI_CFG_ADDTS_RSP_TIMEOUT, &timeout) != eSIR_SUCCESS) { - pe_err("Unable to get Cfg param %d (Addts Rsp Timeout)", + pe_debug("Unable to get Cfg param %d (Addts Rsp Timeout)", WNI_CFG_ADDTS_RSP_TIMEOUT); goto send_failure_addts_rsp; } diff --git a/core/mac/src/pe/lim/lim_send_management_frames.c b/core/mac/src/pe/lim/lim_send_management_frames.c index a67608f3da50..b28eef0de770 100644 --- a/core/mac/src/pe/lim/lim_send_management_frames.c +++ b/core/mac/src/pe/lim/lim_send_management_frames.c @@ -1423,7 +1423,7 @@ lim_send_assoc_rsp_mgmt_frame(tpAniSirGlobal mac_ctx, pe_debug("*** Sending ReAssoc Resp status %d aid %d to", status_code, aid); - lim_print_mac_addr(mac_ctx, mac_hdr->da, LOG1); + lim_print_mac_addr(mac_ctx, mac_hdr->da, LOGD); if (addn_ie_len && addn_ie_len <= WNI_CFG_ASSOC_RSP_ADDNIE_DATA_LEN) qdf_mem_copy(frame + sizeof(tSirMacMgmtHdr) + payload, diff --git a/core/mac/src/pe/lim/lim_utils.c b/core/mac/src/pe/lim/lim_utils.c index b77215216f1d..eb4057c1e744 100644 --- a/core/mac/src/pe/lim/lim_utils.c +++ b/core/mac/src/pe/lim/lim_utils.c @@ -1448,7 +1448,7 @@ lim_update_short_preamble(tpAniSirGlobal mac_ctx, tSirMacAddr peer_mac_addr, pe_debug("Short Preamble is not enabled in Assoc Req from"); - lim_print_mac_addr(mac_ctx, peer_mac_addr, LOG1); + lim_print_mac_addr(mac_ctx, peer_mac_addr, LOGD); for (i = 0; i < LIM_PROT_STA_CACHE_SIZE; i++) { if (LIM_IS_AP_ROLE(psession_entry) && @@ -6569,7 +6569,7 @@ tSirRetStatus lim_strip_ie(tpAniSirGlobal mac_ctx, uint16_t elem_len; if (NULL == addn_ie) { - pe_err("NULL addn_ie pointer"); + pe_debug("NULL addn_ie pointer"); return eSIR_IGNORE_IE; } @@ -6733,7 +6733,7 @@ tSirRetStatus lim_strip_extcap_update_struct(tpAniSirGlobal mac_ctx, NULL, 0, extracted_buff, DOT11F_IE_EXTCAP_MAX_LEN); if (eSIR_SUCCESS != status) { - pe_err("Failed to strip extcap IE status: %d", status); + pe_debug("Failed to strip extcap IE status: %d", status); return status; } diff --git a/core/mac/src/sys/legacy/src/utils/src/parser_api.c b/core/mac/src/sys/legacy/src/utils/src/parser_api.c index 1ec243773511..c93982a0cae1 100644 --- a/core/mac/src/sys/legacy/src/utils/src/parser_api.c +++ b/core/mac/src/sys/legacy/src/utils/src/parser_api.c @@ -1271,14 +1271,10 @@ populate_dot11f_ht_info(tpAniSirGlobal pMac, pHTInfoField1->serviceIntervalGranularity = pMac->lim.gHTServiceIntervalGranularity; - if (psessionEntry == NULL) { - pe_debug("Keep the value retrieved from cfg for secondary channel offset and recommended Tx Width set"); - } else { pHTInfoField1->secondaryChannelOffset = psessionEntry->htSecondaryChannelOffset; pHTInfoField1->recommendedTxWidthSet = psessionEntry->htRecommendedTxWidthSet; - } if ((psessionEntry) && LIM_IS_AP_ROLE(psessionEntry)) { CFG_GET_INT(nSirStatus, pMac, WNI_CFG_HT_INFO_FIELD2, diff --git a/core/sme/src/common/sme_api.c b/core/sme/src/common/sme_api.c index a99f974022c3..703e39c63149 100644 --- a/core/sme/src/common/sme_api.c +++ b/core/sme/src/common/sme_api.c @@ -3107,7 +3107,7 @@ QDF_STATUS sme_get_ap_channel_from_scan_cache( if (0 != first_ap_profile.channelId) { *ap_chnl_id = first_ap_profile.channelId; QDF_TRACE(QDF_MODULE_ID_SME, - QDF_TRACE_LEVEL_ERROR, + QDF_TRACE_LEVEL_DEBUG, FL("Found best AP & its on chnl[%d]"), first_ap_profile.channelId); } else { @@ -6990,7 +6990,7 @@ QDF_STATUS sme_8023_multicast_list(tHalHandle hHal, uint8_t sessionId, if (!CSR_IS_SESSION_VALID(pMac, sessionId) || (!csr_is_conn_state_infra(pMac, sessionId) && !csr_is_ndi_started(pMac, sessionId))) { - QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_WARN, + QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_ERROR, "%s: Unable to find the session Id: %d", __func__, sessionId); return QDF_STATUS_E_FAILURE;