A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-13 08:07:32 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Remove validate_context check from wlan_resume

Browse source 
Presently, there is a very narrow race condition that causes
scheduler_thread to remain in a suspended state for undefined period of
time. The race condition occuers between idle_psoc_timeout and
wlan_hdd_cfg80211_resume_wlan.

As a part of idle_psoc_timeout, the driver calls hdd_wlan_stop_modules
that sets the flag "stop_module_in_progress" and checks if driver is in
suspended state. If yes, it resets the flag and returns. But in the case
of a race condition, before this reset and return is carried out,
wlan_hdd_cfg80211_resume_wlan is invoked. The validate_context inside
the resume function fails due to the above mentioned flag being set. As
a result, resume fails and the driver stays in suspended state. This
causes the driver to enter a infinite loop of stop_modules not being
successful.

To close this small window of contention, remove the validate_context
check. hdd_ctx is always guranteed to be valid and also DSC takes
care of synchronizing the operation, thus the check is redundant.

Change-Id: I723f78e4c33bdc531776c46eff2428dbd869493f
CRs-Fixed: 2616177
This commit is contained in:
Sourav Mohapatra 2020-02-06 17:03:49 +05:30 • committed by nshrivas
commit 5e4000bde8
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
core/hdd/src/wlan_hdd_power.c
View file

@ -1766,12 +1766,6 @@ static int __wlan_hdd_cfg80211_resume_wlan(struct wiphy *wiphy)
goto exit_with_code;
}
exit_code = wlan_hdd_validate_context(hdd_ctx);
if (exit_code) {
hdd_err("Invalid HDD context");
goto exit_with_code;
}
if (hdd_ctx->config->is_wow_disabled) {
hdd_err("wow is disabled");
return -EINVAL;