Revert "(CR) goodix_v1430: load external modules only when probe succeeds"

This reverts commit b5745152b3a6f696506c7c28ad3431b0a9c6078e.

Mot-CRs-fixed: (CR)
Change-Id: I24feaadc62c435ffc60280a654abe7c97f7d3b00
Reviewed-on: https://gerrit.mot.com/1446704
SME-Granted: SME Approvals Granted
SLTApproved: Slta Waiver
Tested-by: Jira Key
Reviewed-by: Konstantin Makariev <kmakariev@motorola.com>
Submit-Approved: Jira Key
This commit is contained in:
Konstantin Makariev 2019-10-30 12:31:33 -05:00 • committed by Konstantin Makariev
commit 5e5e732df9
3 changed files with 0 additions and 11 deletions

View file

@ -184,8 +184,6 @@ static int goodix_cfg_bin_proc(struct goodix_ts_core *core_data)
ts_err("failed get cfg and reg info, update fw then retry");
}
goodix_modules.good2go = true;
/*debug*/
ts_info("cfg_send_flag:0x%04x", ts_dev->reg.cfg_send_flag);
ts_info("pid:0x%04x", ts_dev->reg.pid);

View file

@ -82,11 +82,6 @@ static void __do_register_ext_module(struct work_struct *work)
return;
}
/* driver probe failed */
if (!goodix_modules.good2go) {
ts_err("Can't register ext_module probe failed");
return;
}
ts_info("start register ext_module");
/* prority level *must* be set */
@ -2176,7 +2171,6 @@ static int goodix_ts_probe(struct platform_device *pdev)
ts_err("goodix device confirm failed[skip]");
goto out;
}
goodix_modules.good2go = true;
msleep(100);
/* Try start a thread to get config-bin info */

View file

@ -86,8 +86,6 @@
* @mutex: mutex lock
* @count: current number of registered external module
* @wq: workqueue to do register work
* @good2go: if goodix touch detection failed, then no
* registration is allowed.
* @core_data: core_data pointer
*/
struct goodix_module {
@ -96,7 +94,6 @@ struct goodix_module {
struct mutex mutex;
unsigned int count;
struct workqueue_struct *wq;
bool good2go;
struct completion core_comp;
struct goodix_ts_core *core_data;
};