A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-14 16:46:15 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Remove op_string enum to avoid out of bounds access

Browse source 
Fix potential buffer overflow by array index out of bounds.
We need to add a new op_string entry whenever a new opcode added.
Otherwise, the op_string entry for the additional opcodes could
be accessed out-of-bounds.

Change-Id: Ic09b19916b63d8bb83bf278361b8519268ee1787
CRs-Fixed: 2005340
This commit is contained in:
Yun Park 2017-02-10 10:34:57 -08:00 • committed by Sandeep Puligilla
commit 5f0fc2335f
1 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
core/hdd/src/wlan_hdd_ipa.c
View file

@ -593,14 +593,6 @@ static struct hdd_ipa_tx_hdr ipa_tx_hdr = {
}
};
static const char *op_string[] = {
"TX_SUSPEND",
"TX_RESUME",
"RX_SUSPEND",
"RX_RESUME",
"STATS",
};
static struct hdd_ipa_priv *ghdd_ipa;
/* Local Function Prototypes */
@ -1898,7 +1890,7 @@ static void hdd_ipa_uc_op_cb(struct op_msg_type *op_msg, void *usr_ctxt)
hdd_ipa = (struct hdd_ipa_priv *)hdd_ctx->hdd_ipa;
HDD_IPA_DP_LOG(QDF_TRACE_LEVEL_DEBUG,
"%s, OPCODE %s", __func__, op_string[msg->op_code]);
"OPCODE=%d", msg->op_code);
if ((HDD_IPA_UC_OPCODE_TX_RESUME == msg->op_code) ||
(HDD_IPA_UC_OPCODE_RX_RESUME == msg->op_code)) {