Rationalize fasync return values

Most fasync implementations do something like:

     return fasync_helper(...);

But fasync_helper() will return a positive value at times - a feature used
in at least one place.  Thus, a number of other drivers do:

     err = fasync_helper(...);
     if (err < 0)
             return err;
     return 0;

In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.

Cc: Al Viro <[email protected]>
Signed-off-by: Jonathan Corbet <[email protected]>
This commit is contained in:
Jonathan Corbet 2009-02-01 14:52:56 -07:00
commit 60aa49243d
17 changed files with 22 additions and 73 deletions

View file

@ -432,7 +432,7 @@ static int ioctl_fioasync(unsigned int fd, struct file *filp,
else
error = -ENOTTY;
}
return error;
return error < 0 ? error : 0;
}
static int ioctl_fsfreeze(struct file *filp)