A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-11 15:11:48 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Avoid double memory free of ack_work handler

Browse source 
when the worker thread executes wma_data_tx_ack_work_handler()
as part of driver load/unload, driver frees ack_work but dosent
reset to NULL which results to double memory free in wma_stop()

The fix is to make sure to flush this work and reset to NULL
before the wma_handle gets freed.

Change-Id: I4f56db87256b0f8828c00a2e70158cd76afe1ee0
CRs-Fixed: 2895664
This commit is contained in:
Jyoti Kumari 2021-03-10 14:54:08 +05:30 • committed by snandini
commit 6121eac151
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
core/wma/src/wma_data.c
View file

@ -929,15 +929,13 @@ static void wma_data_tx_ack_work_handler(void *ack_work)
tp_wma_handle wma_handle;
wma_tx_ota_comp_callback ack_cb;
if (cds_is_load_or_unload_in_progress()) {
wma_err("Driver load/unload in progress");
qdf_mem_free(ack_work);
return;
}
work = (struct wma_tx_ack_work_ctx *)ack_work;
wma_handle = work->wma_handle;
if (!wma_handle || cds_is_load_or_unload_in_progress()) {
wma_err("Driver load/unload in progress");
goto end;
}
ack_cb = wma_handle->umac_data_ota_ack_cb;
if (work->status)
@ -951,10 +949,13 @@ static void wma_data_tx_ack_work_handler(void *ack_work)
else
wma_err("Data Tx Ack Cb is NULL");
wma_handle->umac_data_ota_ack_cb = NULL;
wma_handle->last_umac_data_nbuf = NULL;
end:
qdf_mem_free(work);
wma_handle->ack_work_ctx = NULL;
if (wma_handle) {
wma_handle->umac_data_ota_ack_cb = NULL;
wma_handle->last_umac_data_nbuf = NULL;
wma_handle->ack_work_ctx = NULL;
}
}
/**