From 622f2b5797d7008bb16c0e2aaa7f983c4b60435b Mon Sep 17 00:00:00 2001 From: Alok Kumar Date: Tue, 3 Dec 2019 14:14:07 +0530 Subject: [PATCH] qcacld-3.0: Protect pktlog under mutex to avoid possible race conditions Protect pktlog funcitonality under given mutex to avoid possible race condition between pktlog_release/pktlog_open and pktlogmod_exit. Also call pktlogmod_exit before calling wdi_event_detach to avoid accessing freed memory in pktlog release. Change-Id: I452af523338788447f5c2764e883165237083f7d CRs-Fixed: 2087777 --- core/dp/txrx/ol_txrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/dp/txrx/ol_txrx.c b/core/dp/txrx/ol_txrx.c index 8aa0928e0c13..b80a3e065d94 100644 --- a/core/dp/txrx/ol_txrx.c +++ b/core/dp/txrx/ol_txrx.c @@ -1535,6 +1535,8 @@ static void ol_txrx_pdev_pre_detach(struct cdp_pdev *ppdev, int force) OL_RX_REORDER_TRACE_DETACH(pdev); OL_RX_PN_TRACE_DETACH(pdev); + htt_pktlogmod_exit(pdev); + /* * WDI event detach */ @@ -1579,8 +1581,6 @@ static void ol_txrx_pdev_detach(struct cdp_pdev *ppdev, int force) return; } - htt_pktlogmod_exit(pdev); - qdf_spin_lock_bh(&pdev->req_list_spinlock); if (pdev->req_list_depth > 0) ol_txrx_err(