From 79a4656918b6f5a6f6cb84603dadf8eb1093500f Mon Sep 17 00:00:00 2001 From: Odelu Kukatla Date: Fri, 20 Nov 2020 15:53:21 +0530 Subject: [PATCH] interconnect: qcom: Fix the issue with uninitialized variable for Holi There is potential issue where uninitialized variable can be used, so fix it. Change-Id: If725b7efc2979889415da2673c68d4be71e41631 Signed-off-by: Odelu Kukatla --- drivers/interconnect/qcom/holi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/interconnect/qcom/holi.c b/drivers/interconnect/qcom/holi.c index 549eab55884a..d0edbfd1e1e9 100644 --- a/drivers/interconnect/qcom/holi.c +++ b/drivers/interconnect/qcom/holi.c @@ -1800,7 +1800,7 @@ static void qnoc_sync_state(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct qcom_icc_provider *qp = platform_get_drvdata(pdev); - int ret, i; + int ret = 0, i; mutex_lock(&probe_list_lock); probe_count++; @@ -1824,11 +1824,11 @@ static void qnoc_sync_state(struct device *dev) else ret = clk_set_rate(qp->bus_clks[i].clk, qp->bus_clk_cur_rate[i]); - } - if (ret) - pr_err("%s clk_set_rate error: %d\n", - qp->bus_clks[i].id, ret); + if (ret) + pr_err("%s clk_set_rate error: %d\n", + qp->bus_clks[i].id, ret); + } } }