From 661ec9d74a3fb75a7761504df4e5e9a9099c6e88 Mon Sep 17 00:00:00 2001 From: Wu Gao Date: Mon, 2 Jul 2018 11:15:09 +0800 Subject: [PATCH] qcacmn: Verify id before removing idr It causes kernel warning if remove an invalid id. So, verify id before removing idr. Change-Id: I22cd5753a6e4fae0087faaee1c722017523b311e CRs-Fixed: 2271235 --- qdf/linux/src/qdf_idr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qdf/linux/src/qdf_idr.c b/qdf/linux/src/qdf_idr.c index e6c2b7f34341..9749083746b8 100644 --- a/qdf/linux/src/qdf_idr.c +++ b/qdf/linux/src/qdf_idr.c @@ -116,7 +116,8 @@ QDF_STATUS qdf_idr_remove(qdf_idr *idp, int32_t id) return QDF_STATUS_E_INVAL; qdf_spinlock_acquire(&idp->lock); - idr_remove(&idp->idr, id); + if (idr_find(&idp->idr, id)) + idr_remove(&idp->idr, id); qdf_spinlock_release(&idp->lock); return QDF_STATUS_SUCCESS;