From 683585ad7ad14f0945805afb03f8db630d7ffdbf Mon Sep 17 00:00:00 2001 From: Yuchao Ma Date: Tue, 25 Jun 2019 16:11:13 +0800 Subject: [PATCH] disp: msm: sde: remove checks in LTM hist disable function The right_mixer and hist_en checks in LTM hist disable function are not valid for dual display use cases, since in dual display use cases, right_mixer will always be NULL. When device enters suspend state, hist_en will be set to false in sde_cp_crtc_suspend(), and together with the right_mixer check, it will block the ltm buffer lists from resetting and cause LTM has no buffers to use after resume. Change-Id: I51b1b00f4af59e42105322de68019479c65f2fbb Signed-off-by: Yuchao Ma --- msm/sde/sde_color_processing.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/msm/sde/sde_color_processing.c b/msm/sde/sde_color_processing.c index 42dd8a742be3..753121694f95 100644 --- a/msm/sde/sde_color_processing.c +++ b/msm/sde/sde_color_processing.c @@ -2876,15 +2876,9 @@ static void _sde_cp_crtc_disable_ltm_hist(struct sde_crtc *sde_crtc, struct sde_hw_dspp *hw_dspp, struct sde_hw_cp_cfg *hw_cfg) { unsigned long irq_flags; - struct sde_hw_mixer *hw_lm = hw_cfg->mixer_info; u32 i = 0; spin_lock_irqsave(&sde_crtc->ltm_lock, irq_flags); - if (!hw_lm->cfg.right_mixer && !sde_crtc->ltm_hist_en) { - /* histogram is already disabled */ - spin_unlock_irqrestore(&sde_crtc->ltm_lock, irq_flags); - return; - } sde_crtc->ltm_hist_en = false; INIT_LIST_HEAD(&sde_crtc->ltm_buf_free); INIT_LIST_HEAD(&sde_crtc->ltm_buf_busy);