A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-30 03:27:44 -04:00
Code Issues Projects Releases Packages Wiki Activity

remoteproc: imx_rproc: fix return value check in imx_rproc_addr_init()

Browse source 
In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Reviewed-by: Oleksij Rempel <[email protected]>
Signed-off-by: Wei Yongjun <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
This commit is contained in:
Wei Yongjun 2017-10-11 10:48:44 +00:00 • committed by Bjorn Andersson
commit 68a39a3e9f
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/remoteproc/imx_rproc.c
View file

@ -269,10 +269,9 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
att->sa, att->size);
if (IS_ERR(priv->mem[b].cpu_addr)) {
if (!priv->mem[b].cpu_addr) {
dev_err(dev, "devm_ioremap_resource failed\n");
err = PTR_ERR(priv->mem[b].cpu_addr);
return err;
return -ENOMEM;
}
priv->mem[b].sys_addr = att->sa;
priv->mem[b].size = att->size;