From 69ca6965dbfcbd2ae6f1225f978657bd7a360a02 Mon Sep 17 00:00:00 2001 From: Jianmin Zhu Date: Fri, 14 Jun 2019 15:17:04 +0800 Subject: [PATCH] qcacld-3.0: Fix F/W dump on Rome when host F/W out of sync When Rome host F/W out of sync, cds_trigger_recovery_handler is called, but pld_collect_rddm is added in it by change Id9f1dfefe1560affff6c4ecfca1b8fdba3eb0928, Rome doesn't support RDDM, panic will always happen without F/W dump. With this change and ini gEnableSelfRecovery=1, when host F/W out of sync happens, crash inject is sent to F/W to trigger F/W dump, if subsystem restart level is "system", panic will happen, If subsystem restart level is "related", SSR will happen. Change-Id: I3c714e6b2750ef3305b0f4c64ea5fe8fdc74c1d8 CRs-Fixed: 2472484 --- core/cds/src/cds_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/cds/src/cds_api.c b/core/cds/src/cds_api.c index 46696a835ae3..b5955e3dbe64 100644 --- a/core/cds/src/cds_api.c +++ b/core/cds/src/cds_api.c @@ -1803,7 +1803,7 @@ static void cds_trigger_recovery_handler(const char *func, const uint32_t line) if (!in_interrupt() && !irqs_disabled()) { ret = pld_collect_rddm(qdf->dev); - if (ret < 0) + if (ret < 0 && ret != -EOPNOTSUPP) QDF_DEBUG_PANIC("Fail to collect FW ramdump %d", ret); }