From 6a8d39b6edc6628dcae3e80d2c2c746f589482ac Mon Sep 17 00:00:00 2001 From: Dustin Brown Date: Tue, 14 Aug 2018 15:27:26 -0700 Subject: [PATCH] qcacld-3.0: Reduce excessive logging Reduce or removed several excessive log in order to avoid spamming dmesg. Change-Id: I818c8f88f66ad11a3c3bc5d5a12799e83c02e5ff CRs-Fixed: 2296680 --- .../pmo/core/src/wlan_pmo_static_config.c | 2 +- core/cds/src/cds_api.c | 43 ++++++++----------- core/hdd/src/wlan_hdd_cfg80211.c | 4 +- core/hdd/src/wlan_hdd_main.c | 3 +- core/hdd/src/wlan_hdd_napi.c | 2 +- core/sme/src/common/sme_power_save.c | 2 +- 6 files changed, 25 insertions(+), 31 deletions(-) diff --git a/components/pmo/core/src/wlan_pmo_static_config.c b/components/pmo/core/src/wlan_pmo_static_config.c index 85fe1fe408d9..fb52d45bfd0f 100644 --- a/components/pmo/core/src/wlan_pmo_static_config.c +++ b/components/pmo/core/src/wlan_pmo_static_config.c @@ -229,7 +229,7 @@ static QDF_STATUS pmo_configure_ssdp(struct wlan_objmgr_vdev *vdev) vdev_ctx = pmo_vdev_get_priv(vdev); if (!vdev_ctx->pmo_psoc_ctx->psoc_cfg.ssdp) { - pmo_err("mDNS, SSDP, LLMNR patterns are disabled from ini"); + pmo_debug("mDNS, SSDP, LLMNR patterns are disabled from ini"); return QDF_STATUS_SUCCESS; } diff --git a/core/cds/src/cds_api.c b/core/cds/src/cds_api.c index 7b8340ea791c..9e16a6c2b895 100644 --- a/core/cds/src/cds_api.c +++ b/core/cds/src/cds_api.c @@ -848,8 +848,9 @@ exit_with_status: QDF_STATUS cds_enable(struct wlan_objmgr_psoc *psoc) { - QDF_STATUS qdf_status = QDF_STATUS_SUCCESS; + QDF_STATUS qdf_status; struct mac_start_params mac_params; + int errno; /* We support only one instance for now ... */ if (!gp_cds_context) { @@ -857,23 +858,22 @@ QDF_STATUS cds_enable(struct wlan_objmgr_psoc *psoc) return QDF_STATUS_E_FAILURE; } - if ((!gp_cds_context->wma_context) || - (gp_cds_context->mac_context == NULL)) { - if (!gp_cds_context->wma_context) - cds_err("WMA NULL context"); - else - cds_err("MAC NULL context"); + if (!gp_cds_context->wma_context) { + cds_err("WMA NULL context"); + return QDF_STATUS_E_FAILURE; + } + if (!gp_cds_context->mac_context) { + cds_err("MAC NULL context"); return QDF_STATUS_E_FAILURE; } /* Start the wma */ qdf_status = wma_start(); if (qdf_status != QDF_STATUS_SUCCESS) { - cds_err("Failed to start wma"); + cds_err("Failed to start wma; status:%d", qdf_status); return QDF_STATUS_E_FAILURE; } - cds_info("wma correctly started"); /* Start the MAC */ qdf_mem_zero(&mac_params, sizeof(mac_params)); @@ -881,38 +881,33 @@ QDF_STATUS cds_enable(struct wlan_objmgr_psoc *psoc) qdf_status = mac_start(gp_cds_context->mac_context, &mac_params); if (QDF_STATUS_SUCCESS != qdf_status) { - cds_alert("Failed to start MAC"); + cds_err("Failed to start MAC; status:%d", qdf_status); goto err_wma_stop; } - cds_info("MAC correctly started"); - /* START SME */ qdf_status = sme_start(gp_cds_context->mac_context); - if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - cds_alert("Failed to start SME"); + cds_err("Failed to start SME; status:%d", qdf_status); goto err_mac_stop; } - cds_info("SME correctly started"); - - if (cdp_soc_attach_target(cds_get_context(QDF_MODULE_ID_SOC))) { - cds_alert("Failed to attach soc target"); + errno = cdp_soc_attach_target(cds_get_context(QDF_MODULE_ID_SOC)); + if (errno) { + cds_err("Failed to attach soc target; errno:%d", errno); goto err_sme_stop; } - if (cdp_pdev_attach_target(cds_get_context(QDF_MODULE_ID_SOC), - (struct cdp_pdev *)cds_get_context(QDF_MODULE_ID_TXRX))) { - cds_alert("Failed to attach pdev target"); + errno = cdp_pdev_attach_target(cds_get_context(QDF_MODULE_ID_SOC), + cds_get_context(QDF_MODULE_ID_TXRX)); + if (errno) { + cds_err("Failed to attach pdev target; errno:%d", errno); goto err_soc_target_detach; } - cds_info("CDS Start is successful!!"); - qdf_status = dispatcher_psoc_enable(psoc); if (!QDF_IS_STATUS_SUCCESS(qdf_status)) { - cds_alert("dispatcher_psoc_enable failed"); + cds_err("dispatcher_psoc_enable failed; status:%d", qdf_status); goto err_soc_target_detach; } diff --git a/core/hdd/src/wlan_hdd_cfg80211.c b/core/hdd/src/wlan_hdd_cfg80211.c index e3d7bd2fb53d..cca1d802f3f8 100644 --- a/core/hdd/src/wlan_hdd_cfg80211.c +++ b/core/hdd/src/wlan_hdd_cfg80211.c @@ -4118,8 +4118,8 @@ int wlan_hdd_enable_dfs_chan_scan(struct hdd_context *hdd_ctx, mac_handle_t mac_handle; if (enable_dfs_channels == hdd_ctx->config->enableDFSChnlScan) { - hdd_info("DFS channels are already %s", - enable_dfs_channels ? "enabled" : "disabled"); + hdd_debug("DFS channels are already %s", + enable_dfs_channels ? "enabled" : "disabled"); return 0; } diff --git a/core/hdd/src/wlan_hdd_main.c b/core/hdd/src/wlan_hdd_main.c index db0dd2c41cab..88b9437d07ca 100644 --- a/core/hdd/src/wlan_hdd_main.c +++ b/core/hdd/src/wlan_hdd_main.c @@ -10243,9 +10243,8 @@ int hdd_dbs_scan_selection_init(struct hdd_context *hdd_ctx) (CDS_DBS_SCAN_PARAM_PER_CLIENT * CDS_DBS_SCAN_CLIENTS_MAX)); - hdd_info("numentries %hu", numentries); if (!numentries) { - hdd_info("Donot send scan_selection_config"); + hdd_debug("Do not send scan_selection_config"); return 0; } diff --git a/core/hdd/src/wlan_hdd_napi.c b/core/hdd/src/wlan_hdd_napi.c index 6a4e3843dabf..a64f3138b329 100644 --- a/core/hdd/src/wlan_hdd_napi.c +++ b/core/hdd/src/wlan_hdd_napi.c @@ -120,7 +120,7 @@ int hdd_napi_create(void) hdd_err("ERR(%d) creating NAPI instances", rc); } else { - hdd_info("napi instances were created. Map=0x%x", rc); + hdd_debug("napi instances were created. Map=0x%x", rc); hdd_ctx = cds_get_context(QDF_MODULE_ID_HDD); if (unlikely(NULL == hdd_ctx)) { QDF_ASSERT(0); diff --git a/core/sme/src/common/sme_power_save.c b/core/sme/src/common/sme_power_save.c index 4d3066782c0f..8df870b6db2a 100644 --- a/core/sme/src/common/sme_power_save.c +++ b/core/sme/src/common/sme_power_save.c @@ -747,7 +747,7 @@ QDF_STATUS sme_ps_enable_auto_ps_timer(tHalHandle hal_ctx, return QDF_STATUS_SUCCESS; } - sme_info("Start auto_ps_timer for %d ms", timeout); + sme_debug("Start auto_ps_timer for %d ms", timeout); qdf_status = qdf_mc_timer_start(&ps_param->auto_ps_enable_timer, timeout);