From 6aa08d2a70dea70af2db65f95590f7b158c0eee5 Mon Sep 17 00:00:00 2001 From: Tapas Dey Date: Tue, 24 Nov 2020 20:16:10 +0530 Subject: [PATCH] NFC: Fix possible NULL pointer dereference issue Due to possible NULL pointer dereference kw issues are seen. Modify code and add proper NULL check to avoid NULL pointer dereference. Change-Id: Ie9f19fa9ac57a108575c08bdc123313eea3df49c Signed-off-by: Tapas Dey --- drivers/nfc/qti/nfc_common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/nfc/qti/nfc_common.c b/drivers/nfc/qti/nfc_common.c index 12a34d3c8dd2..9b593f8bd51d 100644 --- a/drivers/nfc/qti/nfc_common.c +++ b/drivers/nfc/qti/nfc_common.c @@ -369,10 +369,14 @@ void read_cold_reset_rsp(struct nfc_dev *nfc_dev, char *header) __func__); goto error; } - } else { + } else if (header) { /* For I3C driver, header is read by the worker thread */ memcpy(cold_reset_rsp, header, NCI_HDR_LEN); + + } else { + pr_err("%s: - invalid or NULL header\n", __func__); + goto error; } if ((cold_reset_rsp[0] != COLD_RESET_RSP_GID)