From 6b4643dd58855c4d74ebe2e59f976753fd99ab52 Mon Sep 17 00:00:00 2001 From: Dustin Brown Date: Thu, 9 Feb 2017 12:19:28 -0800 Subject: [PATCH] qcacld-3.0: Make grat ARP KA source/target addresses the same According to RFC 5227, both the source and target addresses in a gratuitous ARP packet should be the same. When enabling gratuitous ARP keepalive, set both source and target addresses to the host's IPv4 address. Change-Id: If467cc7d93adb67f88539ebed727689b61d42089 CRs-Fixed: 2004770 --- core/hdd/src/wlan_hdd_power.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/hdd/src/wlan_hdd_power.c b/core/hdd/src/wlan_hdd_power.c index 9e837d1b2e8b..104928cea195 100644 --- a/core/hdd/src/wlan_hdd_power.c +++ b/core/hdd/src/wlan_hdd_power.c @@ -744,7 +744,6 @@ static int hdd_set_grat_arp_keepalive(hdd_adapter_t *adapter) hdd_station_ctx_t *sta_ctx; tSirKeepAliveReq req = { .packetType = SIR_KEEP_ALIVE_UNSOLICIT_ARP_RSP, - .destIpv4Addr = {0xff, 0xff, 0xff, 0xff}, .dest_macaddr = QDF_MAC_ADDR_BROADCAST_INITIALIZER, }; @@ -771,6 +770,10 @@ static int hdd_set_grat_arp_keepalive(hdd_adapter_t *adapter) return exit_code; } + /* according to RFC5227, sender/target ip address should be the same */ + qdf_mem_copy(&req.destIpv4Addr, &req.hostIpv4Addr, + sizeof(req.destIpv4Addr)); + qdf_copy_macaddr(&req.bssid, &sta_ctx->conn_info.bssId); req.timePeriod = hdd_ctx->config->infraStaKeepAlivePeriod; req.sessionId = adapter->sessionId;