From 6b73bf247d3a38b9e254a168c6853d50f5cd26a4 Mon Sep 17 00:00:00 2001 From: Mihir Ganu Date: Fri, 17 Jul 2020 11:20:00 -0700 Subject: [PATCH] msm: vidc: Check validity of a timestamp before inserting it to list In steady state, the first entry in the linked list of timestamps is always invalid. When adding a new timestamp entry, adding the timestamp which is a duplicate of first entry leads to duplicate linked list nodes. To avoid this, check for validity of an entry before inserting duplicates to the linked list. Change-Id: I47dd8fb06b9e4eb307605df6b0e2b352a2e263fe Signed-off-by: Mihir Ganu --- msm/vidc/msm_vidc_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msm/vidc/msm_vidc_common.c b/msm/vidc/msm_vidc_common.c index 4fd181f268ab..b48c41400867 100644 --- a/msm/vidc/msm_vidc_common.c +++ b/msm/vidc/msm_vidc_common.c @@ -7602,7 +7602,7 @@ int msm_comm_store_timestamp(struct msm_vidc_inst *inst, u64 timestamp_us) duplicate = NULL; list_for_each_entry(node, &inst->timestamps.list, list) { count++; - if (node->timestamp_us == timestamp_us) + if (node->is_valid && node->timestamp_us == timestamp_us) duplicate = node; }