From 6cd6da665d3fcb4d456b44f669ca1daf7539cbaf Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 30 Jul 2020 08:10:22 +0200 Subject: [PATCH] UPSTREAM: modules: mark each_symbol_section static each_symbol_section is only used inside of module.c. Bug: 157965270 Bug: 171277690 Signed-off-by: Christoph Hellwig Signed-off-by: Jessica Yu (cherry picked from commit a54e04914c211b5678602a46b3ede5d82ec1327d) Signed-off-by: Greg Kroah-Hartman Change-Id: I5debe30f150847281874d9b2c47952f9036d37d2 --- include/linux/module.h | 9 --------- kernel/module.c | 3 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/linux/module.h b/include/linux/module.h index 05215b486c1c..70750f8856e1 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -581,15 +581,6 @@ struct symsearch { bool unused; }; -/* - * Walk the exported symbol table - * - * Must be called with module_mutex held or preemption disabled. - */ -bool each_symbol_section(bool (*fn)(const struct symsearch *arr, - struct module *owner, - void *data), void *data); - /* Returns 0 and fills in value, defined and namebuf, or -ERANGE if symnum out of range. */ int module_get_kallsym(unsigned int symnum, unsigned long *value, char *type, diff --git a/kernel/module.c b/kernel/module.c index 436ec9f6478e..b3f4a62f2ae8 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -419,7 +419,7 @@ static bool each_symbol_in_section(const struct symsearch *arr, } /* Returns true as soon as fn returns true, otherwise false. */ -bool each_symbol_section(bool (*fn)(const struct symsearch *arr, +static bool each_symbol_section(bool (*fn)(const struct symsearch *arr, struct module *owner, void *data), void *data) @@ -481,7 +481,6 @@ bool each_symbol_section(bool (*fn)(const struct symsearch *arr, } return false; } -EXPORT_SYMBOL_GPL(each_symbol_section); struct find_symbol_arg { /* Input */