From 6d2641a93434ac29aaa95d378dc8160ce90b1b67 Mon Sep 17 00:00:00 2001 From: Manjeet Singh Date: Thu, 27 Oct 2016 14:18:51 +0530 Subject: [PATCH] qcacld-3.0: Validate hif ctx during shutdown In function wlan_hdd_shutdown, hif_ctx is not validated before use in hif_disable_isr. This can lead to a null pointer exception in certain situations. Validate hif_ctx before use in shutdown function. Change-Id: Id50d87378ee176f6a48a790ec7027994aef0adf8 CRs-Fixed: 1083020 --- core/hdd/src/wlan_hdd_driver_ops.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/hdd/src/wlan_hdd_driver_ops.c b/core/hdd/src/wlan_hdd_driver_ops.c index afee223dcd4d..20290b8f9280 100644 --- a/core/hdd/src/wlan_hdd_driver_ops.c +++ b/core/hdd/src/wlan_hdd_driver_ops.c @@ -450,7 +450,10 @@ static void wlan_hdd_shutdown(void) hdd_err("Host is not ready for SSR, attempting anyway"); if (!QDF_IS_EPPING_ENABLED(cds_get_conparam())) { - hif_disable_isr(hif_ctx); + if (!hif_ctx) + hdd_err("Invalid hif ctx!"); + else + hif_disable_isr(hif_ctx); hdd_wlan_shutdown(); } }