mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-30 19:51:31 -04:00
fs: Make unload_nls() NULL pointer safe
Most call sites of unload_nls() do: if (nls) unload_nls(nls); Check the pointer inside unload_nls() like we do in kfree() and simplify the call sites. Signed-off-by: Thomas Gleixner <[email protected]> Cc: Steve French <[email protected]> Cc: OGAWA Hirofumi <[email protected]> Cc: Roman Zippel <[email protected]> Cc: Dave Kleikamp <[email protected]> Cc: Petr Vandrovec <[email protected]> Cc: Anton Altaparmakov <[email protected]> Signed-off-by: Al Viro <[email protected]>
This commit is contained in:
parent
4504230a71
commit
6d729e44a5
12 changed files with 27 additions and 69 deletions
|
|
@ -178,13 +178,11 @@ static void jfs_put_super(struct super_block *sb)
|
|||
rc = jfs_umount(sb);
|
||||
if (rc)
|
||||
jfs_err("jfs_umount failed with return code %d", rc);
|
||||
if (sbi->nls_tab)
|
||||
unload_nls(sbi->nls_tab);
|
||||
sbi->nls_tab = NULL;
|
||||
|
||||
unload_nls(sbi->nls_tab);
|
||||
|
||||
truncate_inode_pages(sbi->direct_inode->i_mapping, 0);
|
||||
iput(sbi->direct_inode);
|
||||
sbi->direct_inode = NULL;
|
||||
|
||||
kfree(sbi);
|
||||
|
||||
|
|
@ -347,8 +345,7 @@ static int parse_options(char *options, struct super_block *sb, s64 *newLVSize,
|
|||
|
||||
if (nls_map != (void *) -1) {
|
||||
/* Discard old (if remount) */
|
||||
if (sbi->nls_tab)
|
||||
unload_nls(sbi->nls_tab);
|
||||
unload_nls(sbi->nls_tab);
|
||||
sbi->nls_tab = nls_map;
|
||||
}
|
||||
return 1;
|
||||
|
|
|
|||
Loading…
Reference in a new issue