A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-30 03:27:44 -04:00
Code Issues Projects Releases Packages Wiki Activity

coredump: kill MMF_DUMPABLE and MMF_DUMP_SECURELY

Browse source 
Nobody actually needs MMF_DUMPABLE/MMF_DUMP_SECURELY, they are only used
to enforce the encoding of SUID_DUMP_* enum in mm->flags &
MMF_DUMPABLE_MASK.

Now that set_dumpable() updates both bits atomically we can kill them and
simply store the value "as is" in 2 lower bits.

Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Kees Cook <[email protected]>
Cc: Alex Kelly <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Cc: Josh Triplett <[email protected]>
Cc: Petr Matousek <[email protected]>
Cc: Vasily Kulikov <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
Oleg Nesterov 2014-01-23 15:55:32 -08:00 • committed by Linus Torvalds
commit 7288e1187b
2 changed files with 7 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

21
fs/exec.c
View file

@ -1613,33 +1613,24 @@ void set_binfmt(struct linux_binfmt *new)
EXPORT_SYMBOL(set_binfmt);
/*
* set_dumpable converts traditional three-value dumpable to two flags and
* stores them into mm->flags.
* set_dumpable stores three-value SUID_DUMP_* into mm->flags.
*/
void set_dumpable(struct mm_struct *mm, int value)
{
unsigned long old, new;
if (WARN_ON((unsigned)value > SUID_DUMP_ROOT))
return;
do {
old = ACCESS_ONCE(mm->flags);
new = old & ~MMF_DUMPABLE_MASK;
switch (value) {
case SUID_DUMP_ROOT:
new |= (1 << MMF_DUMP_SECURELY);
case SUID_DUMP_USER:
new |= (1<< MMF_DUMPABLE);
}
new = (old & ~MMF_DUMPABLE_MASK) | value;
} while (cmpxchg(&mm->flags, old, new) != old);
}
int __get_dumpable(unsigned long mm_flags)
{
int ret;
ret = mm_flags & MMF_DUMPABLE_MASK;
return (ret > SUID_DUMP_USER) ? SUID_DUMP_ROOT : ret;
return mm_flags & MMF_DUMPABLE_MASK;
}
/*