A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-11 15:11:48 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacld-3.0: Fix double free memory in sme_power_save.c

Browse source 
In sme_ps_enter_wowl_req_params() and sme_ps_exit_wowl_req_params(),
if call to sme_post_ps_msg_to_wma() fails, both caller and callee
frees the message buffer causing double free of memory.

Do not free the memory again in caller function if
sme_post_ps_msg_to_wma returns error.

Change-Id: I92bab9477a07016c44f099e4286178c9d5487a4c
CRs-Fixed: 1076087
This commit is contained in:
Ankit Gupta 2016-10-10 10:15:59 -07:00 • committed by qcabuildsw
commit 72a1c609af
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
core/sme/src/common/sme_power_save.c
View file

@ -394,8 +394,9 @@ static QDF_STATUS sme_ps_enter_wowl_req_params(tpAniSirGlobal mac_ctx,
QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_INFO,
FL("Msg WMA_WOWL_ENTER_REQ Successfully sent to WMA"));
return QDF_STATUS_SUCCESS;
} else
goto end;
} else {
return QDF_STATUS_E_FAILURE;
}
end:
if (hal_wowl_params != NULL)
@ -429,10 +430,9 @@ static QDF_STATUS sme_ps_exit_wowl_req_params(tpAniSirGlobal mac_ctx,
QDF_TRACE(QDF_MODULE_ID_SME, QDF_TRACE_LEVEL_INFO,
FL("Msg WMA_WOWL_EXIT_REQ Successfully sent to WMA"));
return QDF_STATUS_SUCCESS;
} else {
return QDF_STATUS_E_FAILURE;
}
if (hal_wowl_msg != NULL)
qdf_mem_free(hal_wowl_msg);
return QDF_STATUS_E_FAILURE;
}
/**