From 153bf8409ab9a4b9f74b7e69966b2661b4cad4dc Mon Sep 17 00:00:00 2001 From: Raviteja Laggyshetty Date: Tue, 2 May 2023 15:01:17 +0530 Subject: [PATCH] interconnect: qcom: shima: fix UAF under remove function UAF is observed while unloading the interconnect driver. Interconnect is core to the system and should not be unloaded once it is probed. Marking the driver as permanent by removing the module_exit function. Change-Id: I296b40141d3d844f3011cd704e8c593c8bc0f5e0 Signed-off-by: Raviteja Laggyshetty --- drivers/interconnect/qcom/shima.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/interconnect/qcom/shima.c b/drivers/interconnect/qcom/shima.c index f372f4515d28..967386d1f80a 100644 --- a/drivers/interconnect/qcom/shima.c +++ b/drivers/interconnect/qcom/shima.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only /* * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. * */ @@ -2708,11 +2709,5 @@ static int __init qnoc_driver_init(void) } core_initcall(qnoc_driver_init); -static void __exit qnoc_driver_exit(void) -{ - platform_driver_unregister(&qnoc_driver); -} -module_exit(qnoc_driver_exit); - MODULE_DESCRIPTION("Shima NoC driver"); MODULE_LICENSE("GPL v2");