A-Team_Digital_Solutions/android_kernel_motorola_sm6375
Watch
2
0
Fork
You've already forked android_kernel_motorola_sm6375
 0
mirror of https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git synced 2026-10-09 05:39:54 -04:00
Code Issues Projects Releases Packages Wiki Activity

qcacmn: qdf: Introduce QDF_FULL_MAC_FMT and QDF_FULL_MAC_REF

Browse source 
The idea behind introducing these macros is, if the feature
CONFIG_WLAN_TRACE_HIDE_MAC_ADDRESS is enabled, then the
requirement is to hide 2nd, 3rd and 4th octet of the
MAC address in the kernel logs and driver logs.
But other management interfaces like ioctl, debugfs, sysfs,
wext, unit test code or non-production simulator sw (iot_sim)
should continue to log the full mac address.

If the developer directly introduces %pM in the code, it becomes
difficult to catch this in the code review and may end up breaking
the feature CONFIG_WLAN_TRACE_HIDE_MAC_ADDRESS if enabled.

Hence the plan is to introduce meaningful macros to help code
audit easy and with the help of automation, block the developer
from directly introducing %pM in the code.

Change-Id: Id28663eb6e750febba07ed9bdad168187df3248f
CRs-Fixed: 2763028
This commit is contained in:
Srinivas Girigowda 2020-08-25 21:11:26 -07:00 • committed by snandini
commit 738be5f561
1 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
qdf/inc/qdf_types.h
View file

@ -821,6 +821,23 @@ QDF_STATUS qdf_int64_parse(const char *int_str, int64_t *out_int);
QDF_STATUS qdf_uint64_parse(const char *int_str, uint64_t *out_int);
#define QDF_MAC_ADDR_SIZE 6
/**
* If the feature CONFIG_WLAN_TRACE_HIDE_MAC_ADDRESS is enabled,
* then the requirement is to hide 2nd, 3rd and 4th octet of the
* MAC address in the kernel logs and driver logs.
* But other management interfaces like ioctl, debugfs, sysfs,
* wext, unit test code or non-production simulator sw (iot_sim)
* should continue to log the full mac address.
*
* Developers must use QDF_FULL_MAC_FMT instead of "%pM",
* as this macro helps avoid accidentally breaking the feature
* CONFIG_WLAN_TRACE_HIDE_MAC_ADDRESS if enabled and code auditing
* becomes easy.
*/
#define QDF_FULL_MAC_FMT "%pM"
#define QDF_FULL_MAC_REF(a) (a)
#define QDF_MAC_ADDR_STR "%02x:%02x:%02x:%02x:%02x:%02x"
#define QDF_MAC_ADDR_ARRAY(a) (a)[0], (a)[1], (a)[2], (a)[3], (a)[4], (a)[5]