From 74b852a4c313a45ffa8c0fbd082fa1e2d004f01c Mon Sep 17 00:00:00 2001 From: Weilong Wu Date: Fri, 2 Nov 2018 15:02:30 +0800 Subject: [PATCH] dlkm: optimize st21nfc driver Change some logs and optimize the clkreq_gpio operation for st21nfc driver. Change-Id: I1b9b5cdfd711bb2b051d1997124e9211a3b50384 Signed-off-by: Weilong Wu Reviewed-on: https://gerrit.mot.com/1264033 SLTApproved: Slta Waiver SME-Granted: SME Approvals Granted Tested-by: Jira Key Reviewed-by: Balachandar Swami Reviewed-by: Huosheng Liao Submit-Approved: Jira Key --- drivers/nfc/st21nfc/st21nfc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/nfc/st21nfc/st21nfc.c b/drivers/nfc/st21nfc/st21nfc.c index a1c763f1afce..70394eb89c90 100644 --- a/drivers/nfc/st21nfc/st21nfc.c +++ b/drivers/nfc/st21nfc/st21nfc.c @@ -617,14 +617,14 @@ static int st21nfc_probe(struct i2c_client *client, ret = gpio_request(platform_data->irq_gpio, "irq_gpio"); if (ret) { - pr_err("gpio_request failed\n"); + pr_err("irq gpio_request failed\n"); ret = -ENODEV; goto err_free_write_buffer; } ret = gpio_direction_input(platform_data->irq_gpio); if (ret) { - pr_err("gpio_direction_input failed\n"); + pr_err("irq gpio_direction_input failed\n"); ret = -ENODEV; goto err_free_write_buffer; } @@ -632,17 +632,19 @@ static int st21nfc_probe(struct i2c_client *client, if (gpio_is_valid(platform_data->clkreq_gpio)) { ret = gpio_request(platform_data->clkreq_gpio, "clkreq_gpio"); if (ret) { - pr_err("[OPTIONAL] gpio_request failed\n"); + pr_err("clkreq gpio_request failed\n"); ret = -ENODEV; goto err_free_write_buffer; } else { ret = gpio_direction_input(platform_data->clkreq_gpio); if (ret) { - pr_err("[OPTIONAL] gpio_direction_input failed\n"); + pr_err("clkreq gpio_direction_input failed\n"); ret = -ENODEV; goto err_clkreq_gpio; } } + } else { + pr_warn("clkreq gpio not provided. Ext xtal expected\n"); } /* initialize irqIsAttached variable */