ALSA: compress: fix the states to check for allowing read

for reading compressed data, we need to allow when we are paused, draining or
stopped.

Signed-off-by: Vinod Koul <[email protected]>
Cc: Charles Keepax <[email protected]>
Cc: Richard Fitzgerald <[email protected]>
Reviewed-by: Mark Brown <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
This commit is contained in:
Vinod Koul 2013-04-29 14:25:23 +05:30 • committed by Takashi Iwai
commit 754813473c

View file

@ -311,8 +311,16 @@ static ssize_t snd_compr_read(struct file *f, char __user *buf,
stream = &data->stream;
mutex_lock(&stream->device->lock);
/* read is allowed when stream is running */
if (stream->runtime->state != SNDRV_PCM_STATE_RUNNING) {
/* read is allowed when stream is running, paused, draining and setup
* (yes setup is state which we transition to after stop, so if user
* wants to read data after stop we allow that)
*/
switch (stream->runtime->state) {
case SNDRV_PCM_STATE_OPEN:
case SNDRV_PCM_STATE_PREPARED:
case SNDRV_PCM_STATE_XRUN:
case SNDRV_PCM_STATE_SUSPENDED:
case SNDRV_PCM_STATE_DISCONNECTED:
retval = -EBADFD;
goto out;
}