From 781f1b56c91e57d4f735b991cdad641d41ce874b Mon Sep 17 00:00:00 2001 From: Yu Ouyang Date: Thu, 27 Dec 2018 15:24:07 +0800 Subject: [PATCH] qcacld-3.0: correct return value for pld_pcie_get_user_msi_assignment Without CNSS module, function pld_pcie_get_user_msi_assignment return zero even no msi config. For caller function pld_get_user_msi_assignment, zero means TRUE. It will result to panic when deinit sequence called in function hif_ce_srng_msi_free_irq. Return correcly value to avoid panic. Change-Id: Id4480ef1db5357943162472963c4e78d7bfe64b8 CRs-Fixed: 2373130 --- core/pld/src/pld_pcie.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/pld/src/pld_pcie.h b/core/pld/src/pld_pcie.h index 03114ae6ce9f..868948130c6d 100644 --- a/core/pld/src/pld_pcie.h +++ b/core/pld/src/pld_pcie.h @@ -278,7 +278,7 @@ static inline int pld_pcie_get_user_msi_assignment(struct device *dev, uint32_t *user_base_data, uint32_t *base_vector) { - return 0; + return -EINVAL; } static inline int pld_pcie_get_msi_irq(struct device *dev, unsigned int vector)