mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-29 19:21:31 -04:00
rapidio/rio_cm: use memdup_user() instead of duplicating code
Fix coccinelle warning about duplicating existing memdup_user function. Link: http://lkml.kernel.org/r/[email protected] Link: https://lkml.org/lkml/2016/8/11/29 Signed-off-by: Alexandre Bounine <[email protected]> Reported-by: kbuild test robot <[email protected]> Cc: Matt Porter <[email protected]> Cc: Andre van Herk <[email protected]> Cc: Barry Wood <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
0a5bf409d3
commit
7836a2d980
1 changed files with 5 additions and 10 deletions
|
|
@ -1841,24 +1841,19 @@ static int cm_chan_msg_send(void __user *arg)
|
|||
{
|
||||
struct rio_cm_msg msg;
|
||||
void *buf;
|
||||
int ret = 0;
|
||||
int ret;
|
||||
|
||||
if (copy_from_user(&msg, arg, sizeof(msg)))
|
||||
return -EFAULT;
|
||||
if (msg.size > RIO_MAX_MSG_SIZE)
|
||||
return -EINVAL;
|
||||
|
||||
buf = kmalloc(msg.size, GFP_KERNEL);
|
||||
if (!buf)
|
||||
return -ENOMEM;
|
||||
|
||||
if (copy_from_user(buf, (void __user *)(uintptr_t)msg.msg, msg.size)) {
|
||||
ret = -EFAULT;
|
||||
goto out;
|
||||
}
|
||||
buf = memdup_user((void __user *)(uintptr_t)msg.msg, msg.size);
|
||||
if (IS_ERR(buf))
|
||||
return PTR_ERR(buf);
|
||||
|
||||
ret = riocm_ch_send(msg.ch_num, buf, msg.size);
|
||||
out:
|
||||
|
||||
kfree(buf);
|
||||
return ret;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue