mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-30 03:27:44 -04:00
ste_dma40: One check less in d40_prep_sg() after error detection
* Adjust jump targets according to the Linux coding style convention. * Delete a repeated check which became unnecessary with this refactoring. Signed-off-by: Markus Elfring <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Signed-off-by: Vinod Koul <[email protected]>
This commit is contained in:
parent
8452b85906
commit
78c6e1a594
1 changed files with 5 additions and 6 deletions
|
|
@ -2253,7 +2253,7 @@ d40_prep_sg(struct dma_chan *dchan, struct scatterlist *sg_src,
|
|||
|
||||
desc = d40_prep_desc(chan, sg_src, sg_len, dma_flags);
|
||||
if (desc == NULL)
|
||||
goto err;
|
||||
goto unlock;
|
||||
|
||||
if (sg_next(&sg_src[sg_len - 1]) == sg_src)
|
||||
desc->cyclic = true;
|
||||
|
|
@ -2273,7 +2273,7 @@ d40_prep_sg(struct dma_chan *dchan, struct scatterlist *sg_src,
|
|||
if (ret) {
|
||||
chan_err(chan, "Failed to prepare %s sg job: %d\n",
|
||||
chan_is_logical(chan) ? "log" : "phy", ret);
|
||||
goto err;
|
||||
goto free_desc;
|
||||
}
|
||||
|
||||
/*
|
||||
|
|
@ -2285,10 +2285,9 @@ d40_prep_sg(struct dma_chan *dchan, struct scatterlist *sg_src,
|
|||
spin_unlock_irqrestore(&chan->lock, flags);
|
||||
|
||||
return &desc->txd;
|
||||
|
||||
err:
|
||||
if (desc)
|
||||
d40_desc_free(chan, desc);
|
||||
free_desc:
|
||||
d40_desc_free(chan, desc);
|
||||
unlock:
|
||||
spin_unlock_irqrestore(&chan->lock, flags);
|
||||
return NULL;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue