mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-28 02:32:09 -04:00
perf symbols: Robustify reading of build-id from sysfs
Markus reported that perf segfaults when reading /sys/kernel/notes from a kernel linked with GNU gold, due to what looks like a gold bug, so do some bounds checking to avoid crashing in that case. Reported-by: Markus Trippelsdorf <[email protected]> Report-Link: http://lkml.kernel.org/r/20161219161821.GA294@x4 Cc: Adrian Hunter <[email protected]> Cc: David Ahern <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Wang Nan <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
This commit is contained in:
parent
30a9c64448
commit
7934c98a6e
1 changed files with 6 additions and 0 deletions
|
|
@ -537,6 +537,12 @@ int sysfs__read_build_id(const char *filename, void *build_id, size_t size)
|
|||
break;
|
||||
} else {
|
||||
int n = namesz + descsz;
|
||||
|
||||
if (n > (int)sizeof(bf)) {
|
||||
n = sizeof(bf);
|
||||
pr_debug("%s: truncating reading of build id in sysfs file %s: n_namesz=%u, n_descsz=%u.\n",
|
||||
__func__, filename, nhdr.n_namesz, nhdr.n_descsz);
|
||||
}
|
||||
if (read(fd, bf, n) != n)
|
||||
break;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue