mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-28 02:32:09 -04:00
Merge branch 'hash' of git://ftp.sciencehorizons.net/linux
Pull string hash improvements from George Spelvin:
"This series does several related things:
- Makes the dcache hash (fs/namei.c) useful for general kernel use.
(Thanks to Bruce for noticing the zero-length corner case)
- Converts the string hashes in <linux/sunrpc/svcauth.h> to use the
above.
- Avoids 64-bit multiplies in hash_64() on 32-bit platforms. Two
32-bit multiplies will do well enough.
- Rids the world of the bad hash multipliers in hash_32.
This finishes the job started in commit 689de1d6ca ("Minimal
fix-up of bad hashing behavior of hash_64()")
The vast majority of Linux architectures have hardware support for
32x32-bit multiply and so derive no benefit from "simplified"
multipliers.
The few processors that do not (68000, h8/300 and some models of
Microblaze) have arch-specific implementations added. Those
patches are last in the series.
- Overhauls the dcache hash mixing.
The patch in commit 0fed3ac866 ("namei: Improve hash mixing if
CONFIG_DCACHE_WORD_ACCESS") was an off-the-cuff suggestion.
Replaced with a much more careful design that's simultaneously
faster and better. (My own invention, as there was noting suitable
in the literature I could find. Comments welcome!)
- Modify the hash_name() loop to skip the initial HASH_MIX(). This
would let us salt the hash if we ever wanted to.
- Sort out partial_name_hash().
The hash function is declared as using a long state, even though
it's truncated to 32 bits at the end and the extra internal state
contributes nothing to the result. And some callers do odd things:
- fs/hfs/string.c only allocates 32 bits of state
- fs/hfsplus/unicode.c uses it to hash 16-bit unicode symbols not bytes
- Modify bytemask_from_count to handle inputs of 1..sizeof(long)
rather than 0..sizeof(long)-1. This would simplify users other
than full_name_hash"
Special thanks to Bruce Fields for testing and finding bugs in v1. (I
learned some humbling lessons about "obviously correct" code.)
On the arch-specific front, the m68k assembly has been tested in a
standalone test harness, I've been in contact with the Microblaze
maintainers who mostly don't care, as the hardware multiplier is never
omitted in real-world applications, and I haven't heard anything from
the H8/300 world"
* 'hash' of git://ftp.sciencehorizons.net/linux:
h8300: Add <asm/hash.h>
microblaze: Add <asm/hash.h>
m68k: Add <asm/hash.h>
<linux/hash.h>: Add support for architecture-specific functions
fs/namei.c: Improve dcache hash function
Eliminate bad hash multipliers from hash_32() and hash_64()
Change hash_64() return value to 32 bits
<linux/sunrpc/svcauth.h>: Define hash_str() in terms of hashlen_string()
fs/namei.c: Add hashlen_string() function
Pull out string hash to <linux/stringhash.h>
This commit is contained in:
commit
7e0fb73c52
17 changed files with 734 additions and 150 deletions
|
|
@ -16,6 +16,7 @@ config MICROBLAZE
|
|||
select GENERIC_IRQ_SHOW
|
||||
select GENERIC_PCI_IOMAP
|
||||
select GENERIC_SCHED_CLOCK
|
||||
select HAVE_ARCH_HASH
|
||||
select HAVE_ARCH_KGDB
|
||||
select HAVE_DEBUG_KMEMLEAK
|
||||
select HAVE_DMA_API_DEBUG
|
||||
|
|
|
|||
81
arch/microblaze/include/asm/hash.h
Normal file
81
arch/microblaze/include/asm/hash.h
Normal file
|
|
@ -0,0 +1,81 @@
|
|||
#ifndef _ASM_HASH_H
|
||||
#define _ASM_HASH_H
|
||||
|
||||
/*
|
||||
* Fortunately, most people who want to run Linux on Microblaze enable
|
||||
* both multiplier and barrel shifter, but omitting them is technically
|
||||
* a supported configuration.
|
||||
*
|
||||
* With just a barrel shifter, we can implement an efficient constant
|
||||
* multiply using shifts and adds. GCC can find a 9-step solution, but
|
||||
* this 6-step solution was found by Yevgen Voronenko's implementation
|
||||
* of the Hcub algorithm at http://spiral.ece.cmu.edu/mcm/gen.html.
|
||||
*
|
||||
* That software is really not designed for a single multiplier this large,
|
||||
* but if you run it enough times with different seeds, it'll find several
|
||||
* 6-shift, 6-add sequences for computing x * 0x61C88647. They are all
|
||||
* c = (x << 19) + x;
|
||||
* a = (x << 9) + c;
|
||||
* b = (x << 23) + a;
|
||||
* return (a<<11) + (b<<6) + (c<<3) - b;
|
||||
* with variations on the order of the final add.
|
||||
*
|
||||
* Without even a shifter, it's hopless; any hash function will suck.
|
||||
*/
|
||||
|
||||
#if CONFIG_XILINX_MICROBLAZE0_USE_HW_MUL == 0
|
||||
|
||||
#define HAVE_ARCH__HASH_32 1
|
||||
|
||||
/* Multiply by GOLDEN_RATIO_32 = 0x61C88647 */
|
||||
static inline u32 __attribute_const__ __hash_32(u32 a)
|
||||
{
|
||||
#if CONFIG_XILINX_MICROBLAZE0_USE_BARREL
|
||||
unsigned int b, c;
|
||||
|
||||
/* Phase 1: Compute three intermediate values */
|
||||
b = a << 23;
|
||||
c = (a << 19) + a;
|
||||
a = (a << 9) + c;
|
||||
b += a;
|
||||
|
||||
/* Phase 2: Compute (a << 11) + (b << 6) + (c << 3) - b */
|
||||
a <<= 5;
|
||||
a += b; /* (a << 5) + b */
|
||||
a <<= 3;
|
||||
a += c; /* (a << 8) + (b << 3) + c */
|
||||
a <<= 3;
|
||||
return a - b; /* (a << 11) + (b << 6) + (c << 3) - b */
|
||||
#else
|
||||
/*
|
||||
* "This is really going to hurt."
|
||||
*
|
||||
* Without a barrel shifter, left shifts are implemented as
|
||||
* repeated additions, and the best we can do is an optimal
|
||||
* addition-subtraction chain. This one is not known to be
|
||||
* optimal, but at 37 steps, it's decent for a 31-bit multiplier.
|
||||
*
|
||||
* Question: given its size (37*4 = 148 bytes per instance),
|
||||
* and slowness, is this worth having inline?
|
||||
*/
|
||||
unsigned int b, c, d;
|
||||
|
||||
b = a << 4; /* 4 */
|
||||
c = b << 1; /* 1 5 */
|
||||
b += a; /* 1 6 */
|
||||
c += b; /* 1 7 */
|
||||
c <<= 3; /* 3 10 */
|
||||
c -= a; /* 1 11 */
|
||||
d = c << 7; /* 7 18 */
|
||||
d += b; /* 1 19 */
|
||||
d <<= 8; /* 8 27 */
|
||||
d += a; /* 1 28 */
|
||||
d <<= 1; /* 1 29 */
|
||||
d += b; /* 1 30 */
|
||||
d <<= 6; /* 6 36 */
|
||||
return d + c; /* 1 37 total instructions*/
|
||||
#endif
|
||||
}
|
||||
|
||||
#endif /* !CONFIG_XILINX_MICROBLAZE0_USE_HW_MUL */
|
||||
#endif /* _ASM_HASH_H */
|
||||
Loading…
Reference in a new issue