mirror of
https://github.com/BobTheBlinker/android_kernel_motorola_sm6375.git
synced 2026-10-28 18:51:56 -04:00
Remove duplicated unlikely() in IS_ERR()
Some drivers have duplicated unlikely() macros. IS_ERR() already has unlikely() in itself. This patch cleans up such pointless code. Signed-off-by: Hirofumi Nakagawa <[email protected]> Acked-by: David S. Miller <[email protected]> Acked-by: Jeff Garzik <[email protected]> Cc: Paul Clements <[email protected]> Cc: Richard Purdie <[email protected]> Cc: Alessandro Zummo <[email protected]> Cc: David Brownell <[email protected]> Cc: James Bottomley <[email protected]> Cc: Michael Halcrow <[email protected]> Cc: Anton Altaparmakov <[email protected]> Cc: Al Viro <[email protected]> Cc: Carsten Otte <[email protected]> Cc: Patrick McHardy <[email protected]> Cc: Paul Mundt <[email protected]> Cc: Jaroslav Kysela <[email protected]> Cc: Takashi Iwai <[email protected]> Acked-by: Mike Frysinger <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
This commit is contained in:
parent
9a6f70bbed
commit
801678c5a3
17 changed files with 23 additions and 23 deletions
|
|
@ -272,7 +272,7 @@ static int audit_to_watch(struct audit_krule *krule, char *path, int len,
|
|||
return -EINVAL;
|
||||
|
||||
watch = audit_init_watch(path);
|
||||
if (unlikely(IS_ERR(watch)))
|
||||
if (IS_ERR(watch))
|
||||
return PTR_ERR(watch);
|
||||
|
||||
audit_get_watch(watch);
|
||||
|
|
@ -848,7 +848,7 @@ static struct audit_watch *audit_dupe_watch(struct audit_watch *old)
|
|||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
new = audit_init_watch(path);
|
||||
if (unlikely(IS_ERR(new))) {
|
||||
if (IS_ERR(new)) {
|
||||
kfree(path);
|
||||
goto out;
|
||||
}
|
||||
|
|
@ -989,7 +989,7 @@ static void audit_update_watch(struct audit_parent *parent,
|
|||
audit_set_auditable(current->audit_context);
|
||||
|
||||
nwatch = audit_dupe_watch(owatch);
|
||||
if (unlikely(IS_ERR(nwatch))) {
|
||||
if (IS_ERR(nwatch)) {
|
||||
mutex_unlock(&audit_filter_mutex);
|
||||
audit_panic("error updating watch, skipping");
|
||||
return;
|
||||
|
|
@ -1004,7 +1004,7 @@ static void audit_update_watch(struct audit_parent *parent,
|
|||
list_del_rcu(&oentry->list);
|
||||
|
||||
nentry = audit_dupe_rule(&oentry->rule, nwatch);
|
||||
if (unlikely(IS_ERR(nentry)))
|
||||
if (IS_ERR(nentry))
|
||||
audit_panic("error updating watch, removing");
|
||||
else {
|
||||
int h = audit_hash_ino((u32)ino);
|
||||
|
|
@ -1785,7 +1785,7 @@ int audit_update_lsm_rules(void)
|
|||
watch = entry->rule.watch;
|
||||
tree = entry->rule.tree;
|
||||
nentry = audit_dupe_rule(&entry->rule, watch);
|
||||
if (unlikely(IS_ERR(nentry))) {
|
||||
if (IS_ERR(nentry)) {
|
||||
/* save the first error encountered for the
|
||||
* return value */
|
||||
if (!err)
|
||||
|
|
|
|||
Loading…
Reference in a new issue